| Message ID | 20220509032836.1116866-2-kaehndan@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add generic serial MIDI driver using serial bus API | expand |
On Sun, 08 May 2022 22:28:35 -0500, Daniel Kaehn wrote: > Adds dt-binding for a Generic MIDI Interface using a serial device. > > Signed-off-by: Daniel Kaehn <kaehndan@gmail.com> > --- > .../bindings/sound/serial-midi.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/serial-midi.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/sound/serial-midi.example.dts:20.25-24.11: Warning (unit_address_vs_reg): /example-0/serial@7e201400: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/sound/serial-midi.example.dts:25.25-30.11: Warning (unit_address_vs_reg): /example-0/serial@7e201600: node has a unit name, but no reg or ranges property doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/sound/serial-midi.yaml b/Documentation/devicetree/bindings/sound/serial-midi.yaml new file mode 100644 index 000000000000..74849be01df3 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/serial-midi.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause + +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/serial-midi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic Serial MIDI Interface + +maintainers: + - Daniel Kaehn <kaehndan@gmail.com> + +description: + Generic MIDI interface using a serial device. This denotes that a serial device is + dedicated to MIDI communication, either to an external MIDI device through a DIN5 + or other connector, or to a known hardwired MIDI controller. This device must be a + child node of a serial node. + + Can only be set to use standard baud rates corresponding to supported rates of the + parent serial device. If the standard MIDI baud of 31.25 kBaud is needed + (as would be the case if interfacing with arbitrary external MIDI devices), + configure the clocks of the parent serial device so that a requested baud of 38.4 kBaud + resuts in the standard MIDI baud rate, and set the 'current-speed' property to 38400 (default) + +properties: + compatible: + const: serial-midi + + current-speed: + description: Baudrate to set the serial port to when this MIDI device is opened. + default: 38400 + +required: + - compatible + +additionalProperties: false + +examples: + - | + serial@7e201400 { + midi { + compatible = "serial-midi"; + }; + }; + serial@7e201600 { + midi { + compatible = "serial-midi"; + current-speed = <115200>; + }; + };
Adds dt-binding for a Generic MIDI Interface using a serial device. Signed-off-by: Daniel Kaehn <kaehndan@gmail.com> --- .../bindings/sound/serial-midi.yaml | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/serial-midi.yaml