diff mbox series

ALSA: seq: replace ternary operator with max()

Message ID 20220517062518.123292-1-guozhengkui@vivo.com (mailing list archive)
State Accepted
Commit 44d30762cde76fe0a5b2e955ec34b369815679d6
Headers show
Series ALSA: seq: replace ternary operator with max() | expand

Commit Message

Guo Zhengkui May 17, 2022, 6:25 a.m. UTC 
Fix the following coccicheck warning:

sound/core/seq/seq_ports.c:142:12-14: WARNING opportunity for max()

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 sound/core/seq/seq_ports.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai May 17, 2022, 6:50 a.m. UTC | #1 
On Tue, 17 May 2022 08:25:17 +0200,
Guo Zhengkui wrote:
> 
> Fix the following coccicheck warning:
> 
> sound/core/seq/seq_ports.c:142:12-14: WARNING opportunity for max()
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>

Thanks, applied now.


Takashi
diff mbox series

Patch

diff --git a/sound/core/seq/seq_ports.c b/sound/core/seq/seq_ports.c
index 84d78630463e..25fcf5a2c71c 100644
--- a/sound/core/seq/seq_ports.c
+++ b/sound/core/seq/seq_ports.c
@@ -139,7 +139,7 @@  struct snd_seq_client_port *snd_seq_create_port(struct snd_seq_client *client,
 	port_subs_info_init(&new_port->c_dest);
 	snd_use_lock_use(&new_port->use_lock);
 
-	num = port >= 0 ? port : 0;
+	num = max(port, 0);
 	mutex_lock(&client->ports_mutex);
 	write_lock_irq(&client->ports_lock);
 	list_for_each_entry(p, &client->ports_list_head, list) {