| Message ID | 20220526203708.1723898-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: da732x: Drop no-op remove function | expand |
On 26 May 2022 21:37, Uwe Kleine-König wrote: > A remove callback that just returns 0 is equivalent to no callback at all > as can be seen in i2c_device_remove(). So simplify accordingly. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Adam Thomson <DLG-Adam.Thomson.Opensource@dm.renesas.com>
diff --git a/sound/soc/codecs/da732x.c b/sound/soc/codecs/da732x.c index 42d6a3fc3af5..267936015cb8 100644 --- a/sound/soc/codecs/da732x.c +++ b/sound/soc/codecs/da732x.c @@ -1547,11 +1547,6 @@ static int da732x_i2c_probe(struct i2c_client *i2c, return ret; } -static int da732x_i2c_remove(struct i2c_client *client) -{ - return 0; -} - static const struct i2c_device_id da732x_i2c_id[] = { { "da7320", 0}, { } @@ -1563,7 +1558,6 @@ static struct i2c_driver da732x_i2c_driver = { .name = "da7320", }, .probe = da732x_i2c_probe, - .remove = da732x_i2c_remove, .id_table = da732x_i2c_id, };
A remove callback that just returns 0 is equivalent to no callback at all as can be seen in i2c_device_remove(). So simplify accordingly. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- sound/soc/codecs/da732x.c | 6 ------ 1 file changed, 6 deletions(-) base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f