| Message ID | 20220526204016.1724630-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: lm49453: Drop no-op remove function | expand |
Hello,
FTR: The two registered maintainers (M R Swami Reddy, Vishwas A
Deshpande) didn't get my patch. The TI mail server told me:
vishwas.a.deshpande@ti.com
host cluster5.us.messagelabs.com [67.219.247.195]
SMTP error from remote mail server after RCPT TO:<vishwas.a.deshpande@ti.com>:
550 Invalid recipient <vishwas.a.deshpande@ti.com> (#5.1.1)
mr.swami.reddy@ti.com
host cluster5.us.messagelabs.com [67.219.246.212]
SMTP error from remote mail server after RCPT TO:<mr.swami.reddy@ti.com>:
550 Invalid recipient <mr.swami.reddy@ti.com> (#5.1.1)
So if the only stopper to apply this patch is some feedback from one of
them: please reconsider :-)
What should happen to the maintainer entry?
Best regards
Uwe
diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c index 973d781b4b6a..86cead5022c0 100644 --- a/sound/soc/codecs/lm49453.c +++ b/sound/soc/codecs/lm49453.c @@ -1443,11 +1443,6 @@ static int lm49453_i2c_probe(struct i2c_client *i2c, return ret; } -static int lm49453_i2c_remove(struct i2c_client *client) -{ - return 0; -} - static const struct i2c_device_id lm49453_i2c_id[] = { { "lm49453", 0 }, { } @@ -1459,7 +1454,6 @@ static struct i2c_driver lm49453_i2c_driver = { .name = "lm49453", }, .probe = lm49453_i2c_probe, - .remove = lm49453_i2c_remove, .id_table = lm49453_i2c_id, };
A remove callback that just returns 0 is equivalent to no callback at all as can be seen in i2c_device_remove(). So simplify accordingly. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- sound/soc/codecs/lm49453.c | 6 ------ 1 file changed, 6 deletions(-) base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f