Message ID | 20220616220427.136036-3-pierre-louis.bossart@linux.intel.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 7213170a9515109322f75c08b5268d8e9cdad8e4 |
Headers | show |
Series | ASoC: use pm_runtime_resume_and_get() when possible | expand |
On 2022-06-17 12:04 AM, Pierre-Louis Bossart wrote: > The current code does not check for errors and does not release the > reference on errors. Thanks for the fixes. Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c index 55f310e91b55c..9d72ebd812af9 100644 --- a/sound/soc/intel/skylake/skl-pcm.c +++ b/sound/soc/intel/skylake/skl-pcm.c @@ -1380,7 +1380,10 @@ static int skl_platform_soc_probe(struct snd_soc_component *component) const struct skl_dsp_ops *ops; int ret; - pm_runtime_get_sync(component->dev); + ret = pm_runtime_resume_and_get(component->dev); + if (ret < 0 && ret != -EACCES) + return ret; + if (bus->ppcap) { skl->component = component;