diff mbox series

[-next,1/3] ASoC: amd: acp: add missing platform_device_unregister() in acp_pci_probe()

Message ID 20220819073758.1273160-1-yangyingliang@huawei.com (mailing list archive)
State Accepted
Commit 6a4ce20fd776d2fd19ffaf85cf34a53761e2c888
Headers show
Series [-next,1/3] ASoC: amd: acp: add missing platform_device_unregister() in acp_pci_probe() | expand

Commit Message

Yang Yingliang Aug. 19, 2022, 7:37 a.m. UTC
Add missing platform_device_unregister() in error path in acp_pci_probe().

Fixes: c49f5e74a11e ("ASoC: amd: acp: Add error handling cases")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 sound/soc/amd/acp/acp-pci.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Brown Aug. 19, 2022, 10:47 p.m. UTC | #1
On Fri, 19 Aug 2022 15:37:56 +0800, Yang Yingliang wrote:
> Add missing platform_device_unregister() in error path in acp_pci_probe().
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: amd: acp: add missing platform_device_unregister() in acp_pci_probe()
      commit: 6a4ce20fd776d2fd19ffaf85cf34a53761e2c888
[2/3] ASoC: amd: acp: switch to use dev_err_probe()
      commit: f89a8c5bb3489e43ff87b5f91acc8db66a168e8e
[3/3] ASoC: amd: acp: add a label to make error path more clean
      commit: fd8ec75207588f85c622ee49e5f32267d2406d92

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/amd/acp/acp-pci.c b/sound/soc/amd/acp/acp-pci.c
index 2c8e960cc9a6..5bb23ebe1216 100644
--- a/sound/soc/amd/acp/acp-pci.c
+++ b/sound/soc/amd/acp/acp-pci.c
@@ -104,6 +104,7 @@  static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id
 	addr = pci_resource_start(pci, 0);
 	chip->base = devm_ioremap(&pci->dev, addr, pci_resource_len(pci, 0));
 	if (!chip->base) {
+		platform_device_unregister(dmic_dev);
 		ret = -ENOMEM;
 		goto release_regions;
 	}