diff mbox series

ASoC: SOF: Fix compilation when HDA_AUDIO_CODEC config is disabled

Message ID 20220819122908.3563930-1-cezary.rojewski@intel.com (mailing list archive)
State Superseded
Headers show
Series ASoC: SOF: Fix compilation when HDA_AUDIO_CODEC config is disabled | expand

Commit Message

Cezary Rojewski Aug. 19, 2022, 12:29 p.m. UTC
hda_codec_device_init() expects three parameters, not two.

Fixes: f2183b08c81a ("ASoC: Intel: Drop hdac_ext usage for codec device creation")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
 sound/soc/sof/intel/hda-codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Aug. 19, 2022, 12:31 p.m. UTC | #1
On Fri, Aug 19, 2022 at 02:29:08PM +0200, Cezary Rojewski wrote:
> hda_codec_device_init() expects three parameters, not two.
> 
> Fixes: f2183b08c81a ("ASoC: Intel: Drop hdac_ext usage for codec device creation")

This commit doesn't appear to exist upstream.  Did you mean
3fd63658caed9494cca1d4789a66d3d2def2a0ab from Takashi's tree?
Cezary Rojewski Aug. 19, 2022, 12:35 p.m. UTC | #2
On 2022-08-19 2:31 PM, Mark Brown wrote:
> On Fri, Aug 19, 2022 at 02:29:08PM +0200, Cezary Rojewski wrote:
>> hda_codec_device_init() expects three parameters, not two.
>>
>> Fixes: f2183b08c81a ("ASoC: Intel: Drop hdac_ext usage for codec device creation")
> 
> This commit doesn't appear to exist upstream.  Did you mean
> 3fd63658caed9494cca1d4789a66d3d2def2a0ab from Takashi's tree?

Indeed, thanks. Fixing as we speak.
diff mbox series

Patch

diff --git a/sound/soc/sof/intel/hda-codec.c b/sound/soc/sof/intel/hda-codec.c
index 73336648cd25..1e9afc48394c 100644
--- a/sound/soc/sof/intel/hda-codec.c
+++ b/sound/soc/sof/intel/hda-codec.c
@@ -213,7 +213,7 @@  static int hda_codec_probe(struct snd_sof_dev *sdev, int address,
 		put_device(&codec->core.dev);
 	}
 #else
-	codec = hda_codec_device_init(&hbus->core, address);
+	codec = hda_codec_device_init(&hbus->core, address, HDA_DEV_ASOC);
 	ret = PTR_ERR_OR_ZERO(codec);
 #endif