ALSA: patch_realtek: Fix Dell Inspiron Plus 16

Commit Message

Philipp Jungkamp Sept. 14, 2022, 7:28 a.m. UTC

The Dell Inspiron Plus 16 has top speakers connected on NID 0x17, which
the codec reports as unconnected.
These speakers should be connected to the DAC on NID 0x03.
---
I don't possess this Laptop myself. The owner of this Laptop reports
that the speakers are now active, though there are still problem's.

> There are still 2 small issues present:
> 1. 0,5s delay before the top speakers turn on
> 2. Popping sound from headphones 5s after the music stops playing
> and afterwards when it starts playing again. This can be fixed by
> disabling power save on the audio driver [...].

I've only written this patch because the issue seemed similar to that
on my Lenovo Yoga 9 14IAP7.

 sound/pci/hda/patch_realtek.c | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

--
2.37.3

Comments

Takashi Iwai Sept. 14, 2022, 7:37 a.m. UTC | #1

On Wed, 14 Sep 2022 09:28:04 +0200,
Philipp Jungkamp wrote:
> 
> The Dell Inspiron Plus 16 has top speakers connected on NID 0x17, which
> the codec reports as unconnected.
> These speakers should be connected to the DAC on NID 0x03.

Could you give your Signed-off-by line?  It's mandatory.

> ---
> I don't possess this Laptop myself. The owner of this Laptop reports
> that the speakers are now active, though there are still problem's.
> 
> > There are still 2 small issues present:
> > 1. 0,5s delay before the top speakers turn on

Likely a hardware feature.  We may add some delay at the runtime
resume, if that matters, too.

> > 2. Popping sound from headphones 5s after the music stops playing
> > and afterwards when it starts playing again. This can be fixed by
> > disabling power save on the audio driver [...].

You can try some other quirk.  You can try to apply
alc_fixup_no_shutup() as a start.


thanks,

Takashi

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 38930cf5aace..e6f229e418c3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6896,6 +6896,32 @@  static void alc287_fixup_yoga9_14iap7_bass_spk_pin(struct hda_codec *codec,
 	}
 }

+static void alc295_fixup_dell_inspiron_top_speakers(struct hda_codec *codec,
+					  const struct hda_fixup *fix, int action)
+{
+	static const struct hda_pintbl pincfgs[] = {
+		{ 0x14, 0x90170151 },
+		{ 0x17, 0x90170150 },
+		{ }
+	};
+	static const hda_nid_t conn[] = { 0x02, 0x03 };
+	static const hda_nid_t preferred_pairs[] = {
+		0x14, 0x02,
+		0x17, 0x03,
+		0x21, 0x02,
+		0
+	};
+	struct alc_spec *spec = codec->spec;
+
+	switch (action) {
+	case HDA_FIXUP_ACT_PRE_PROBE:
+		snd_hda_apply_pincfgs(codec, pincfgs);
+		snd_hda_override_conn_list(codec, 0x17, ARRAY_SIZE(conn), conn);
+		spec->gen.preferred_dacs = preferred_pairs;
+		break;
+	}
+}
+
 enum {
 	ALC269_FIXUP_GPIO2,
 	ALC269_FIXUP_SONY_VAIO,
@@ -7137,6 +7163,7 @@  enum {
 	ALC287_FIXUP_LEGION_16ITHG6,
 	ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK,
 	ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN,
+	ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS,
 };

 /* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -9066,6 +9093,12 @@  static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK,
 	},
+	[ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = alc295_fixup_dell_inspiron_top_speakers,
+		.chained = true,
+		.chain_id = ALC269_FIXUP_DELL4_MIC_NO_PRESENCE,
+	},
 };

 static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -9165,6 +9198,7 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1028, 0x0a9d, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x0a9e, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x0b19, "Dell XPS 15 9520", ALC289_FIXUP_DUAL_SPK),
+	SND_PCI_QUIRK(0x1028, 0x0b71, "Dell Inspiron 16 Plus 7620", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS),
 	SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),