| Message ID | 20220917123517.229153-1-rf@opensource.cirrus.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soundwire: cadence: Write to correct address for each FIFO chunk | expand |
On 9/17/22 14:35, Richard Fitzgerald wrote: > _cdns_xfer_msg() must add the fragment offset to msg->addr to get the > base target address of each FIFO chunk. Otherwise every chunk will > be written to the first 32 register addresses. > > Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> > --- > drivers/soundwire/cadence_master.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c > index 3ef472049980..ca241bbeadd9 100644 > --- a/drivers/soundwire/cadence_master.c > +++ b/drivers/soundwire/cadence_master.c > @@ -569,7 +569,7 @@ _cdns_xfer_msg(struct sdw_cdns *cdns, struct sdw_msg *msg, int cmd, > } > > base = CDNS_MCP_CMD_BASE; > - addr = msg->addr; > + addr = msg->addr + offset; LGTM, probably means that sending a large command broken in several pieces never worked. D'oh. Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Thanks Richard! > > for (i = 0; i < count; i++) { > data = FIELD_PREP(CDNS_MCP_CMD_DEV_ADDR, msg->dev_num);
On 17-09-22, 13:35, Richard Fitzgerald wrote: > _cdns_xfer_msg() must add the fragment offset to msg->addr to get the > base target address of each FIFO chunk. Otherwise every chunk will > be written to the first 32 register addresses. Applied, thanks
diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c index 3ef472049980..ca241bbeadd9 100644 --- a/drivers/soundwire/cadence_master.c +++ b/drivers/soundwire/cadence_master.c @@ -569,7 +569,7 @@ _cdns_xfer_msg(struct sdw_cdns *cdns, struct sdw_msg *msg, int cmd, } base = CDNS_MCP_CMD_BASE; - addr = msg->addr; + addr = msg->addr + offset; for (i = 0; i < count; i++) { data = FIELD_PREP(CDNS_MCP_CMD_DEV_ADDR, msg->dev_num);
_cdns_xfer_msg() must add the fragment offset to msg->addr to get the base target address of each FIFO chunk. Otherwise every chunk will be written to the first 32 register addresses. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> --- drivers/soundwire/cadence_master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)