diff mbox series

ASoC: es8316: fix register sync error in suspend/resume tests

Message ID 20220922095912.27010-1-pierre-louis.bossart@linux.intel.com (mailing list archive)
State Accepted
Commit 6de0b0292b548010b09917e8cdfc337a6dcf67ce
Headers show
Series ASoC: es8316: fix register sync error in suspend/resume tests | expand

Commit Message

Pierre-Louis Bossart Sept. 22, 2022, 9:59 a.m. UTC 
The SOF CI tests report failures with the following error thrown

kernel: es8316 i2c-ESSX8336:00: Unable to sync registers 0x0-0x1. -121

ES8336 only supports I2C read/write one byte a time, so we do need to
set the .use_single_read and .use_single_write flags to avoid this
sync issue.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: FRED OH <fred.oh@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
 sound/soc/codecs/es8316.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Mark Brown Sept. 22, 2022, 5:53 p.m. UTC | #1 
On Thu, 22 Sep 2022 11:59:12 +0200, Pierre-Louis Bossart wrote:
> The SOF CI tests report failures with the following error thrown
> 
> kernel: es8316 i2c-ESSX8336:00: Unable to sync registers 0x0-0x1. -121
> 
> ES8336 only supports I2C read/write one byte a time, so we do need to
> set the .use_single_read and .use_single_write flags to avoid this
> sync issue.
> 
> [...]

Applied to

   broonie/sound.git for-linus

Thanks!

[1/1] ASoC: es8316: fix register sync error in suspend/resume tests
      commit: 6de0b0292b548010b09917e8cdfc337a6dcf67ce

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c
index 8643014472ae6..056c3082fe02c 100644
--- a/sound/soc/codecs/es8316.c
+++ b/sound/soc/codecs/es8316.c
@@ -815,6 +815,8 @@  static const struct regmap_access_table es8316_volatile_table = {
 static const struct regmap_config es8316_regmap = {
 	.reg_bits = 8,
 	.val_bits = 8,
+	.use_single_read = true,
+	.use_single_write = true,
 	.max_register = 0x53,
 	.volatile_table	= &es8316_volatile_table,
 	.cache_type = REGCACHE_RBTREE,