| Message ID | 20220927140948.17696-3-shangxiaojing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c54402609820427ff6f725f9182216e7cfe7cfa7 |
| Headers | show |
| Series | ASoC: Use DIV_ROUND_UP() instead of open-coding it | expand |
On Tue, Sep 27, 2022 at 10:09:46PM +0800, Shang XiaoJing wrote: > Use DIV_ROUND_UP() instead of open-coding it, which intents and makes it > more clear what is going on for the casual reviewer. > > The Coccinelle references Commit e4d8aef21403 ("ALSA: usb: Use > DIV_ROUND_UP() instead of open-coding it"). > > Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
diff --git a/sound/soc/codecs/wm8978.c b/sound/soc/codecs/wm8978.c index a682f8020eb6..aa2f55401a88 100644 --- a/sound/soc/codecs/wm8978.c +++ b/sound/soc/codecs/wm8978.c @@ -498,7 +498,7 @@ static int wm8978_configure_pll(struct snd_soc_component *component) if (4 * f_opclk < 3 * f_mclk) /* Have to use OPCLKDIV */ - opclk_div = (3 * f_mclk / 4 + f_opclk - 1) / f_opclk; + opclk_div = DIV_ROUND_UP(3 * f_mclk / 4, f_opclk); else opclk_div = 1;
Use DIV_ROUND_UP() instead of open-coding it, which intents and makes it more clear what is going on for the casual reviewer. The Coccinelle references Commit e4d8aef21403 ("ALSA: usb: Use DIV_ROUND_UP() instead of open-coding it"). Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> --- sound/soc/codecs/wm8978.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)