| Message ID | 20220927141110.18033-1-shangxiaojing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | eefe77fdc0de86480f5dbb6bc721396d82d095d3 |
| Headers | show |
| Series | [-next] ALSA: sb: Use DIV_ROUND_UP() instead of open-coding it | expand |
On Tue, 27 Sep 2022 16:11:10 +0200, Shang XiaoJing wrote: > > Use DIV_ROUND_UP() instead of open-coding it, which intents and makes > it more clear what is going on for the casual reviewer. > > The Coccinelle references Commit e4d8aef21403 ("ALSA: usb: Use > DIV_ROUND_UP() instead of open-coding it"). > > Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> Thanks, applied. Takashi
diff --git a/sound/isa/sb/emu8000_pcm.c b/sound/isa/sb/emu8000_pcm.c index f8d90a1e989b..c8afc4347c54 100644 --- a/sound/isa/sb/emu8000_pcm.c +++ b/sound/isa/sb/emu8000_pcm.c @@ -236,7 +236,7 @@ static int emu8k_pcm_open(struct snd_pcm_substream *subs) /* use timer to update periods.. (specified in msec) */ snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_PERIOD_TIME, - (1000000 + HZ - 1) / HZ, UINT_MAX); + DIV_ROUND_UP(1000000, HZ), UINT_MAX); return 0; }
Use DIV_ROUND_UP() instead of open-coding it, which intents and makes it more clear what is going on for the casual reviewer. The Coccinelle references Commit e4d8aef21403 ("ALSA: usb: Use DIV_ROUND_UP() instead of open-coding it"). Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> --- sound/isa/sb/emu8000_pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)