| Message ID | 20221021190908.1502026-4-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add missing dt-binding properties to rt5682(s) | expand |
On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: > The rt5682 codec can have three supplies: AVDD, MICVDD and VBAT. Add > properties for them. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > > Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt > index c5f2b8febcee..5ccf4eaf12a9 100644 > --- a/Documentation/devicetree/bindings/sound/rt5682.txt > +++ b/Documentation/devicetree/bindings/sound/rt5682.txt > @@ -48,6 +48,12 @@ Optional properties: > > - #sound-dai-cells: Should be set to '<0>'. > > +- AVDD-supply: phandle to the regulator supplying AVDD > + > +- MICVDD-supply: phandle to the regulator supplying MICVDD > + > +- VBAT-supply: phandle to the regulator supplying VBAT Lowercase. Best regards, Krzysztof
On Sat, Oct 22, 2022 at 12:41:01PM -0400, Krzysztof Kozlowski wrote: > On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: > > The rt5682 codec can have three supplies: AVDD, MICVDD and VBAT. Add > > properties for them. > > > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > > > Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt > > index c5f2b8febcee..5ccf4eaf12a9 100644 > > --- a/Documentation/devicetree/bindings/sound/rt5682.txt > > +++ b/Documentation/devicetree/bindings/sound/rt5682.txt > > @@ -48,6 +48,12 @@ Optional properties: > > > > - #sound-dai-cells: Should be set to '<0>'. > > > > +- AVDD-supply: phandle to the regulator supplying AVDD > > + > > +- MICVDD-supply: phandle to the regulator supplying MICVDD > > + > > +- VBAT-supply: phandle to the regulator supplying VBAT > > Lowercase. Actually looks like there's already a DT using these properties before the binding was added: arm64/boot/dts/qcom/sc7180-trogdor.dtsi In this case should we keep them uppercase for compatibility or carry on with the name changes and also update the DT? (the driver also uses uppercase names) Also noticed that dai-cells should actually be 1. Will fix in next version. Thanks, Nícolas
On 24/10/2022 12:00, Nícolas F. R. A. Prado wrote: > On Sat, Oct 22, 2022 at 12:41:01PM -0400, Krzysztof Kozlowski wrote: >> On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: >>> The rt5682 codec can have three supplies: AVDD, MICVDD and VBAT. Add >>> properties for them. >>> >>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> >>> --- >>> >>> Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt >>> index c5f2b8febcee..5ccf4eaf12a9 100644 >>> --- a/Documentation/devicetree/bindings/sound/rt5682.txt >>> +++ b/Documentation/devicetree/bindings/sound/rt5682.txt >>> @@ -48,6 +48,12 @@ Optional properties: >>> >>> - #sound-dai-cells: Should be set to '<0>'. >>> >>> +- AVDD-supply: phandle to the regulator supplying AVDD >>> + >>> +- MICVDD-supply: phandle to the regulator supplying MICVDD >>> + >>> +- VBAT-supply: phandle to the regulator supplying VBAT >> >> Lowercase. > > Actually looks like there's already a DT using these properties before the > binding was added: > > arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > In this case should we keep them uppercase for compatibility or carry on with > the name changes and also update the DT? (the driver also uses uppercase names) Driver seems to use them as well, then uppercase is fine. But you need to describe it in commit msg, that you document existing usage, not adding new properties. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt index c5f2b8febcee..5ccf4eaf12a9 100644 --- a/Documentation/devicetree/bindings/sound/rt5682.txt +++ b/Documentation/devicetree/bindings/sound/rt5682.txt @@ -48,6 +48,12 @@ Optional properties: - #sound-dai-cells: Should be set to '<0>'. +- AVDD-supply: phandle to the regulator supplying AVDD + +- MICVDD-supply: phandle to the regulator supplying MICVDD + +- VBAT-supply: phandle to the regulator supplying VBAT + Pins on the device (for linking into audio routes) for RT5682: * DMIC L1
The rt5682 codec can have three supplies: AVDD, MICVDD and VBAT. Add properties for them. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++ 1 file changed, 6 insertions(+)