| Message ID | 20221024220015.1759428-4-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 07b16192f3f01d002d8ff37dcd4372980330ea93 |
| Headers | show |
| Series | Add missing dt-binding properties to rt5682(s) | expand |
Il 25/10/22 00:00, Nícolas F. R. A. Prado ha scritto: > Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") > defined the sound-dai-cells property as 0. However, rt5682 has two DAIs, > AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix > it. > > Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On 24/10/2022 18:00, Nícolas F. R. A. Prado wrote: > Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") > defined the sound-dai-cells property as 0. However, rt5682 has two DAIs, > AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix > it. > > Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Oct 24, 2022 at 3:02 PM Nícolas F. R. A. Prado <nfraprado@collabora.com> wrote: > > Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") > defined the sound-dai-cells property as 0. However, rt5682 has two DAIs, > AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix > it. > > Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt index c5f2b8febcee..6b87db68337c 100644 --- a/Documentation/devicetree/bindings/sound/rt5682.txt +++ b/Documentation/devicetree/bindings/sound/rt5682.txt @@ -46,7 +46,7 @@ Optional properties: - realtek,dmic-clk-driving-high : Set the high driving of the DMIC clock out. -- #sound-dai-cells: Should be set to '<0>'. +- #sound-dai-cells: Should be set to '<1>'. Pins on the device (for linking into audio routes) for RT5682:
Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") defined the sound-dai-cells property as 0. However, rt5682 has two DAIs, AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix it. Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- Changes in v2: - Added this commit Documentation/devicetree/bindings/sound/rt5682.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)