diff mbox series

[v4,1/2] ASoC: mediatek: dt-bindings: modify machine bindings for two MICs case

Message ID 20221030172609.1635096-2-ajye_huang@compal.corp-partner.google.com (mailing list archive)
State Superseded
Headers show
Series Modify documentation and machine driver for mt8186_rt1019_rt5682s sound card | expand

Commit Message

Ajye Huang Oct. 30, 2022, 5:26 p.m. UTC
Add a property "dmic-gpios" for switching between two MICs.

Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
Change-Id: I5b59ac23e761fdc078a2227da14fe170c8df6388
---
 .../sound/mt8186-mt6366-rt1019-rt5682s.yaml         | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

Comments

Ajye Huang Oct. 31, 2022, 12:07 p.m. UTC | #1
Hi Rob Herring,


On Mon, Oct 31, 2022 at 1:26 AM Ajye Huang
<ajye_huang@compal.corp-partner.google.com> wrote:
>
> +
> +        dmic-gpios = <&pio 23 0>;
>
>          headset-codec {
>              sound-dai = <&rt5682s>;
> --
> 2.25.1
>

I think the modification will be better, I will send v5 again, thanks
@@ -63,14 +70,19 @@ required:

 examples:
   - |
+    #include <dt-bindings/gpio/gpio.h>

     sound: mt8186-sound {
         compatible = "mediatek,mt8186-mt6366-rt1019-rt5682s-sound";
         mediatek,platform = <&afe>;
         pinctrl-names = "aud_clk_mosi_off",
-                        "aud_clk_mosi_on";
+                        "aud_clk_mosi_on",
+                        "aud_gpio_dmic_sec";
         pinctrl-0 = <&aud_clk_mosi_off>;
         pinctrl-1 = <&aud_clk_mosi_on>;
+        pinctrl-2 = <&aud_gpio_dmic_sec>;
+
+        dmic-gpios = <&pio 23 GPIO_ACTIVE_HIGH>;

         headset-codec {
             sound-dai = <&rt5682s>;
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/mt8186-mt6366-rt1019-rt5682s.yaml b/Documentation/devicetree/bindings/sound/mt8186-mt6366-rt1019-rt5682s.yaml
index 4fc5b045d3cf..8c24cd1f1906 100644
--- a/Documentation/devicetree/bindings/sound/mt8186-mt6366-rt1019-rt5682s.yaml
+++ b/Documentation/devicetree/bindings/sound/mt8186-mt6366-rt1019-rt5682s.yaml
@@ -21,6 +21,13 @@  properties:
     $ref: "/schemas/types.yaml#/definitions/phandle"
     description: The phandle of MT8186 ASoC platform.
 
+  dmic-gpios:
+    maxItems: 1
+    description:
+      dmic-gpios optional prop for switching between two DMICs.
+      Ex, the GPIO can control a MUX HW component to select
+      dmic clk and data form a Front or Rear dmic.
+
   headset-codec:
     type: object
     additionalProperties: false
@@ -68,9 +75,13 @@  examples:
         compatible = "mediatek,mt8186-mt6366-rt1019-rt5682s-sound";
         mediatek,platform = <&afe>;
         pinctrl-names = "aud_clk_mosi_off",
-                        "aud_clk_mosi_on";
+                        "aud_clk_mosi_on",
+                        "aud_gpio_dmic_sec";
         pinctrl-0 = <&aud_clk_mosi_off>;
         pinctrl-1 = <&aud_clk_mosi_on>;
+        pinctrl-2 = <&aud_gpio_dmic_sec>;
+
+        dmic-gpios = <&pio 23 0>;
 
         headset-codec {
             sound-dai = <&rt5682s>;