diff mbox series

Revert "ALSA: usb-audio: Drop superfluous interface setup at parsing"

Message ID 20230104150944.24918-1-tiwai@suse.de (mailing list archive)
State New, archived
Headers show
Series Revert "ALSA: usb-audio: Drop superfluous interface setup at parsing" | expand

Commit Message

Takashi Iwai Jan. 4, 2023, 3:09 p.m. UTC
This reverts commit ac5e2fb425e1121ceef2b9d1b3ffccc195d55707.

The commit caused a regression on Behringer UMC404HD (and likely
others).  As the change was meant only as a minor optimization, it's
better to revert it to address the regression.

Reported-and-tested-by: Michael Ralston <michael@ralston.id.au>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/CAC2975JXkS1A5Tj9b02G_sy25ZWN-ys+tc9wmkoS=qPgKCogSg@mail.gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
 sound/usb/stream.c | 6 ++++++
 1 file changed, 6 insertions(+)
diff mbox series


diff --git a/sound/usb/stream.c b/sound/usb/stream.c
index f75601ca2d52..f10f4e6d3fb8 100644
--- a/sound/usb/stream.c
+++ b/sound/usb/stream.c
@@ -1222,6 +1222,12 @@  static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip,
 			if (err < 0)
 				return err;
+		/* try to set the interface... */
+		usb_set_interface(chip->dev, iface_no, 0);
+		snd_usb_init_pitch(chip, fp);
+		snd_usb_init_sample_rate(chip, fp, fp->rate_max);
+		usb_set_interface(chip->dev, iface_no, altno);
 	return 0;