| Message ID | 20230111161144.3275546-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | aea11bcddcafc7f548c4fa574cb6019e7690008d |
| Headers | show |
| Series | [1/1] ASoC: fsl_sai: Use dev_err_probe | expand |
On Thu, Jan 12, 2023 at 12:11 AM Alexander Stein < alexander.stein@ew.tq-group.com> wrote: > This helps figuring out why the device probe is deferred, e.g. missing > FSL_EDMA driver. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com> Best regards Wang Shengjiu > --- > Old: > root@ls1021:~# cat /sys/kernel/debug/devices_deferred > sound fsl-asoc-card: snd_soc_register_card failed: -517 > 2b50000.sai > > New: > root@ls1021:~# cat /sys/kernel/debug/devices_deferred > sound fsl-asoc-card: snd_soc_register_card failed: -517 > 2b50000.sai fsl-sai: Registering PCM dmaengine failed > > sound/soc/fsl/fsl_sai.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c > index 1c9be8a5dcb13..2a38e2bdf9893 100644 > --- a/sound/soc/fsl/fsl_sai.c > +++ b/sound/soc/fsl/fsl_sai.c > @@ -1458,14 +1458,17 @@ static int fsl_sai_probe(struct platform_device > *pdev) > if (sai->soc_data->use_imx_pcm) { > ret = imx_pcm_dma_init(pdev); > if (ret) { > + dev_err_probe(dev, ret, "PCM DMA init failed\n"); > if (!IS_ENABLED(CONFIG_SND_SOC_IMX_PCM_DMA)) > dev_err(dev, "Error: You must enable the > imx-pcm-dma support!\n"); > goto err_pm_get_sync; > } > } else { > ret = devm_snd_dmaengine_pcm_register(dev, NULL, 0); > - if (ret) > + if (ret) { > + dev_err_probe(dev, ret, "Registering PCM dmaengine > failed\n"); > goto err_pm_get_sync; > + } > } > > ret = devm_snd_soc_register_component(dev, &fsl_component, > -- > 2.34.1 > >
On Wed, 11 Jan 2023 17:11:44 +0100, Alexander Stein wrote: > This helps figuring out why the device probe is deferred, e.g. missing > FSL_EDMA driver. > > Applied to broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_sai: Use dev_err_probe commit: aea11bcddcafc7f548c4fa574cb6019e7690008d All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index 1c9be8a5dcb13..2a38e2bdf9893 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -1458,14 +1458,17 @@ static int fsl_sai_probe(struct platform_device *pdev) if (sai->soc_data->use_imx_pcm) { ret = imx_pcm_dma_init(pdev); if (ret) { + dev_err_probe(dev, ret, "PCM DMA init failed\n"); if (!IS_ENABLED(CONFIG_SND_SOC_IMX_PCM_DMA)) dev_err(dev, "Error: You must enable the imx-pcm-dma support!\n"); goto err_pm_get_sync; } } else { ret = devm_snd_dmaengine_pcm_register(dev, NULL, 0); - if (ret) + if (ret) { + dev_err_probe(dev, ret, "Registering PCM dmaengine failed\n"); goto err_pm_get_sync; + } } ret = devm_snd_soc_register_component(dev, &fsl_component,
This helps figuring out why the device probe is deferred, e.g. missing FSL_EDMA driver. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Old: root@ls1021:~# cat /sys/kernel/debug/devices_deferred sound fsl-asoc-card: snd_soc_register_card failed: -517 2b50000.sai New: root@ls1021:~# cat /sys/kernel/debug/devices_deferred sound fsl-asoc-card: snd_soc_register_card failed: -517 2b50000.sai fsl-sai: Registering PCM dmaengine failed sound/soc/fsl/fsl_sai.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)