| Message ID | 20230214103757.36624-1-andy.chi@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9251584af09285133bec0595e5c7218fe2e595c9 |
| Headers | show |
| Series | [v2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops | expand |
On Tue, 14 Feb 2023 11:37:56 +0100, Andy Chi wrote: > > On HP Laptops, requires the same ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED quirk to > make its audio LEDs work. Well, this quirk is not only about mute/mic LED but rather mainly for enabling the Cirrus amp. I suppose the speaker didn't work without this quirk, too? Takashi
On 2/14/23 19:27, Takashi Iwai wrote: > On Tue, 14 Feb 2023 11:37:56 +0100, > Andy Chi wrote: >> On HP Laptops, requires the same ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED quirk to >> make its audio LEDs work. > Well, this quirk is not only about mute/mic LED but rather mainly for > enabling the Cirrus amp. I suppose the speaker didn't work without > this quirk, too? Ah, right. I'll send out v3. Sorry for that. > > > Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 7b9fb38ff732..e2cd5456f2a6 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9432,6 +9432,12 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8b43, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8b44, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8b45, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8b46, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8b47, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x8b7a, "HP", ALC236_FIXUP_HP_GPIO_LED),
On HP Laptops, requires the same ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED quirk to make its audio LEDs work. Signed-off-by: Andy Chi <andy.chi@canonical.com> v2: Modify the commit message to the correct quirk. --- sound/pci/hda/patch_realtek.c | 6 ++++++ 1 file changed, 6 insertions(+)