From patchwork Wed Mar 15 15:04:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13176060 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62485C6FD1D for ; Wed, 15 Mar 2023 15:09:53 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0A6B11268; Wed, 15 Mar 2023 16:09:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0A6B11268 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678892991; bh=NleyZkadgk6QDJ9AqpB9dnDZQQnygS3aIOAaaGjbqlE=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=cklkiB4U28KsalwcX9gXw7t61SCVf/WI1JmfzFwfsXAqYvi6aa0DjE/H3l2eWewIi iULM6+/IQYKz1z6P3A6Yn/sFTM4oCqe0KLnGlHXzG05wggPfQDJHMeVKhC6m1HnOI4 e6MKDNVjYF9Ct8qbyohIIdmMS6PAKOfSw7wIvmSo= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 618F6F80564; Wed, 15 Mar 2023 16:08:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2F7ECF8052E; Wed, 15 Mar 2023 16:08:08 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6927EF80423 for ; Wed, 15 Mar 2023 16:08:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6927EF80423 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcSjP-00075V-C5; Wed, 15 Mar 2023 16:07:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pcSjO-004KTj-Ja; Wed, 15 Mar 2023 16:07:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pcSjM-0057bv-Ml; Wed, 15 Mar 2023 16:07:56 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jaroslav Kysela , Takashi Iwai Subject: [PATCH 001/173] ALSA: sh: aica: Drop if blocks with always false condition Date: Wed, 15 Mar 2023 16:04:53 +0100 Message-Id: <20230315150745.67084-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=909; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=NleyZkadgk6QDJ9AqpB9dnDZQQnygS3aIOAaaGjbqlE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkEd0qs7Vjm/klISlUsENliYlRQVLOL0A39QHid 5PingNhNn6JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZBHdKgAKCRDB/BR4rcrs CfJnB/9IQjPAAdkuu0yHGMPD+CRdj0sddTmcFmUue7wbUH+eLiN+EQ5uuMMrWndABVT6fozG2nL dvpmCrKNAcDYxOTyBbwFSUR6JsqEpRIlvoxYxSe/nIsZiONh2Ov2iTLqRuzjsvXqLuunFShr/kc kWltb8AkX3ouAtCTJFqWVVx4GRMMVJZt14NDlCACjwpZokV4WMa9jYQgYvvf1W3lIxMsDb+Wyv4 rEqqBEWDc6LNa/0PJRifEu4vLjwaAIMm3PazpCPeJ7zqnSm6l4sR+RHfBlA3eLxdpg7ZY0fqh3C Rl0H8RCcC6p6RK2/fetolX8ylsGxPQbj/RH0Vf9RAm3Uf9MD X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Message-ID-Hash: JVP2U2SELQS6WFISLTIRC5YDT7X7MMIK X-Message-ID-Hash: JVP2U2SELQS6WFISLTIRC5YDT7X7MMIK X-MailFrom: ukl@pengutronix.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, kernel@pengutronix.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: snd_aica_remove() is only called after a successful call to snd_aica_probe(). With the latter it's sure that platform_set_drvdata() was called with a non-NULL argument. So platform_get_drvdata() won't return NULL and the check can be dropped. This prepares converting platform driver remove callbacks to return void. Signed-off-by: Uwe Kleine-König --- sound/sh/aica.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/sh/aica.c b/sound/sh/aica.c index 6e9d6bd67369..459c907655d9 100644 --- a/sound/sh/aica.c +++ b/sound/sh/aica.c @@ -543,8 +543,6 @@ static int snd_aica_remove(struct platform_device *devptr) { struct snd_card_aica *dreamcastcard; dreamcastcard = platform_get_drvdata(devptr); - if (unlikely(!dreamcastcard)) - return -ENODEV; snd_card_free(dreamcastcard->card); kfree(dreamcastcard); return 0;