From patchwork Wed Mar 15 15:05:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13176120 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DD27C61DA4 for ; Wed, 15 Mar 2023 15:18:43 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5293A12DC; Wed, 15 Mar 2023 16:17:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5293A12DC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678893521; bh=UWIspkVrEgQ3JI/RAPubyHlp7BRu+ORadNNQVIKreBE=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=AOOez9W7DUK5vPsDEHBCBssPNwRr/fr5/z2L0LIoDgsPi8ZTBC5MlRQY2nH9qZVQd aRXdM0mP35dzT6bUM4DyWpI2PZrDuwCqavFREizWojULs4GmU+59O3p9gvu7+99Di7 DOxFO0jaTmdDXYCO508PdcxNCSHba8cpy/JdKmnI= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 824F3F8060D; Wed, 15 Mar 2023 16:10:37 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 55960F80652; Wed, 15 Mar 2023 16:08:52 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1DB04F80571 for ; Wed, 15 Mar 2023 16:08:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1DB04F80571 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcSjX-0007Te-MW; Wed, 15 Mar 2023 16:08:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pcSjW-004KWy-W2; Wed, 15 Mar 2023 16:08:07 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pcSjW-0057ee-2m; Wed, 15 Mar 2023 16:08:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Charles Keepax , Richard Fitzgerald , James Schulman , David Rhodes , Lucas Tanure , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Subject: [PATCH 044/173] ASoC: codecs: cs47l35: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 16:05:36 +0100 Message-Id: <20230315150745.67084-45-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1777; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=UWIspkVrEgQ3JI/RAPubyHlp7BRu+ORadNNQVIKreBE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkEd2sUE8A4lUx+7sGPprwWeHKFpPMuqjeS84lz 7YMbFmrJbSJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZBHdrAAKCRDB/BR4rcrs CU8BB/9UlI0wKnu1fG5Y1xSIWmssUBzF6m76yO4cmH3Q2ZCWqEo65UsTetb0/QswizDLey0stW4 gDRcndMH0bNkQRKpWBJ0YtXnCd3pkT2IRWMPnI+ZldXrZ/WPc0W4de5e0zwHU2aZPo617jj7Jx3 V6IAn31QWKw6GKH2+XvgwDc7IA4SizsiNg9Q0vrTRu7jgjZF1j0Qv1pgK09PqCSGIpbB1qLUSDM f0aTkLXOMod0HZp6+gdXaNsxq/QGsC+6nfSxsSFHQBvxvZZ/h5L7swQiinyUoPfxcpD4BUdBKH/ K61wOfJAMRKs5re4CarDnhZHLgSueSqKHgAkk1ro+98nKnWT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Message-ID-Hash: 7TDNIJ4MGDCUE65WP2SCMSTRSAK2CRH3 X-Message-ID-Hash: 7TDNIJ4MGDCUE65WP2SCMSTRSAK2CRH3 X-MailFrom: ukl@pengutronix.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, kernel@pengutronix.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Charles Keepax --- sound/soc/codecs/cs47l35.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/cs47l35.c b/sound/soc/codecs/cs47l35.c index c1032d6c9143..c05c80c16c84 100644 --- a/sound/soc/codecs/cs47l35.c +++ b/sound/soc/codecs/cs47l35.c @@ -1744,7 +1744,7 @@ static int cs47l35_probe(struct platform_device *pdev) return ret; } -static int cs47l35_remove(struct platform_device *pdev) +static void cs47l35_remove(struct platform_device *pdev) { struct cs47l35 *cs47l35 = platform_get_drvdata(pdev); int i; @@ -1758,8 +1758,6 @@ static int cs47l35_remove(struct platform_device *pdev) madera_free_irq(cs47l35->core.madera, MADERA_IRQ_DSP_IRQ1, cs47l35); madera_free_overheat(&cs47l35->core); madera_core_free(&cs47l35->core); - - return 0; } static struct platform_driver cs47l35_codec_driver = { @@ -1767,7 +1765,7 @@ static struct platform_driver cs47l35_codec_driver = { .name = "cs47l35-codec", }, .probe = &cs47l35_probe, - .remove = &cs47l35_remove, + .remove_new = cs47l35_remove, }; module_platform_driver(cs47l35_codec_driver);