From patchwork Wed Mar 15 15:06:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13176168 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93D98C61DA4 for ; Wed, 15 Mar 2023 15:31:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7293D13B3; Wed, 15 Mar 2023 16:30:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7293D13B3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678894281; bh=mAfToYYRajwhEI7ApvCPU/bfjlrvkX0rl1TSVQcFKpA=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=AFuXC2sJ6zD3lLlP+RbFCS7Rt8yAn6ql+OYvLI/IwcnDaZZHqjXhHNtvwEyivBcA3 NTjKpE6KzQmv10W7vLJ4idfkhrD63ulbkdLdFoyqztZpnRlER7ABv3t07iAwFEkREB 8GgiWAiw9HORgfA6bQFHpa6UIiYdNi+SixMYgI3s= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id BB78FF80716; Wed, 15 Mar 2023 16:13:05 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 787B0F805C5; Wed, 15 Mar 2023 16:09:42 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5D8ACF805E1 for ; Wed, 15 Mar 2023 16:08:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5D8ACF805E1 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcSjj-00085v-Fg; Wed, 15 Mar 2023 16:08:19 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pcSjg-004KaL-UF; Wed, 15 Mar 2023 16:08:16 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pcSjf-0057hM-Ni; Wed, 15 Mar 2023 16:08:15 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Charles Keepax , Minghao Chi Subject: [PATCH 086/173] ASoC: img: img-i2s-in: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 16:06:18 +0100 Message-Id: <20230315150745.67084-87-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1599; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=mAfToYYRajwhEI7ApvCPU/bfjlrvkX0rl1TSVQcFKpA=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkEd4vd0v46P7Yl/1RPIgkF5oYs0XAfOZ0/xvXa DCyJhMqWnCJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZBHeLwAKCRDB/BR4rcrs CY1uB/4zcfMe+xNhNTJFAG5nGDuJIpvbeYBY9RBRujNUFjTp8JaA58H8HoXuJY+jbwd59lLDb8v YY8pOJcgYM+E4JDTXbsDg0trgWekvySqn3gI3vqUBj5bLtA3O9szAP9/ljFY+ZPnImYZ7sf7M+6 1Efjjpkpb4Gbsr98HW5DVpCYvSj7OxkcO5yDXCTJPCeZHwZnDSVQoHS4gKj6r5eInZ0nHwnSLur e5TZGM6fBoKDoSTvutD23KMG9YkX3qs4587oOWFsGa4+ntSazlLcqf3nxHLDKgSdzqbYrBkPUvB eslmcwWwmJcR2GBy4ha/nk9/rB+ZPYIk2H5EV7XJvMfOwU9t X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Message-ID-Hash: G4LI2CYDIK2STAOQXIPPQB2XLCZ3ELSO X-Message-ID-Hash: G4LI2CYDIK2STAOQXIPPQB2XLCZ3ELSO X-MailFrom: ukl@pengutronix.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, kernel@pengutronix.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- sound/soc/img/img-i2s-in.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c index 56bb7bbd3976..b7ab8467b5cf 100644 --- a/sound/soc/img/img-i2s-in.c +++ b/sound/soc/img/img-i2s-in.c @@ -532,13 +532,11 @@ static int img_i2s_in_probe(struct platform_device *pdev) return ret; } -static int img_i2s_in_dev_remove(struct platform_device *pdev) +static void img_i2s_in_dev_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); if (!pm_runtime_status_suspended(&pdev->dev)) img_i2s_in_runtime_suspend(&pdev->dev); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -609,7 +607,7 @@ static struct platform_driver img_i2s_in_driver = { .pm = &img_i2s_in_pm_ops }, .probe = img_i2s_in_probe, - .remove = img_i2s_in_dev_remove + .remove_new = img_i2s_in_dev_remove }; module_platform_driver(img_i2s_in_driver);