| Message ID | 20230616090156.2347850-3-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 08432e59c7d9a958e69cf6b7a03777ba4f26f10b |
| Headers | show |
| Series | [1/4] ASoC: max98388: fix unused function warnings | expand |
On 6/16/23 02:00, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The new driver fails to build when PCI is disabled: > > WARNING: unmet direct dependencies detected for SND_SOC_LOONGSON_I2S_PCI > Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && (LOONGARCH || COMPILE_TEST [=y]) && PCI [=n] > Selected by [y]: > - SND_SOC_LOONGSON_CARD [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && (LOONGARCH || COMPILE_TEST [=y]) > sound/soc/loongson/loongson_i2s_pci.c:167:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int] > module_pci_driver(loongson_i2s_driver); > > Add the appropriate Kconfig dependency. > > Fixes: d24028606e764 ("ASoC: loongson: Add Loongson ASoC Sound Card Support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Thanks. > --- > sound/soc/loongson/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/loongson/Kconfig b/sound/soc/loongson/Kconfig > index c175f9de19a85..b8d7e2bade246 100644 > --- a/sound/soc/loongson/Kconfig > +++ b/sound/soc/loongson/Kconfig > @@ -16,6 +16,7 @@ config SND_SOC_LOONGSON_I2S_PCI > config SND_SOC_LOONGSON_CARD > tristate "Loongson Sound Card Driver" > select SND_SOC_LOONGSON_I2S_PCI > + depends on PCI > help > Say Y or M if you want to add support for SoC audio using > loongson I2S controller.
diff --git a/sound/soc/loongson/Kconfig b/sound/soc/loongson/Kconfig index c175f9de19a85..b8d7e2bade246 100644 --- a/sound/soc/loongson/Kconfig +++ b/sound/soc/loongson/Kconfig @@ -16,6 +16,7 @@ config SND_SOC_LOONGSON_I2S_PCI config SND_SOC_LOONGSON_CARD tristate "Loongson Sound Card Driver" select SND_SOC_LOONGSON_I2S_PCI + depends on PCI help Say Y or M if you want to add support for SoC audio using loongson I2S controller.