diff mbox series

ALSA: fireface: make read-only const array for model names static

Message ID 20230627235406.289970-1-o-takashi@sakamocchi.jp (mailing list archive)
State Accepted
Commit a64db0b9dfac2011e14e88faf59847baac1dad5a
Headers show
Series ALSA: fireface: make read-only const array for model names static | expand

Commit Message

Takashi Sakamoto June 27, 2023, 11:54 p.m. UTC
It is preferable not to populate the constant array for constant strings
on the stack.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/fireface/ff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai June 28, 2023, 9:43 a.m. UTC | #1
On Wed, 28 Jun 2023 01:54:06 +0200,
Takashi Sakamoto wrote:
> 
> It is preferable not to populate the constant array for constant strings
> on the stack.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Thanks, applied now.


Takashi
diff mbox series

Patch

diff --git a/sound/firewire/fireface/ff.c b/sound/firewire/fireface/ff.c
index 82241058ea14..6e84e4787259 100644
--- a/sound/firewire/fireface/ff.c
+++ b/sound/firewire/fireface/ff.c
@@ -16,7 +16,7 @@  MODULE_LICENSE("GPL");
 static void name_card(struct snd_ff *ff)
 {
 	struct fw_device *fw_dev = fw_parent_device(ff->unit);
-	const char *const names[] = {
+	static const char *const names[] = {
 		[SND_FF_UNIT_VERSION_FF800]	= "Fireface800",
 		[SND_FF_UNIT_VERSION_FF400]	= "Fireface400",
 		[SND_FF_UNIT_VERSION_UFX]	= "FirefaceUFX",