diff mbox series

[v2,4/5] kunit: Enable ASoC in all_tests.config

Message ID 20230718-asoc-topology-kunit-enable-v2-4-0ee11e662b92@kernel.org (mailing list archive)
State Accepted
Commit 5aaa4024e14f8b878a348338a74b4c97bc2478b1
Headers show
Series ASoC: Improve coverage in default KUnit runs | expand

Commit Message

Mark Brown July 18, 2023, 12:28 a.m. UTC
There are KUnit tests for some of the ASoC utility functions which are
not enabled in the KUnit all_tests.config, do so.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 tools/testing/kunit/configs/all_tests.config | 4 ++++
 1 file changed, 4 insertions(+)

Comments

David Gow July 18, 2023, 9:03 a.m. UTC | #1
On Tue, 18 Jul 2023 at 08:30, Mark Brown <broonie@kernel.org> wrote:
>
> There are KUnit tests for some of the ASoC utility functions which are
> not enabled in the KUnit all_tests.config, do so.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---

If the other patches go through, this is great for me. (I've already
used it to test some in-progress changes with the struct device
handling.)

I'm happy to take this via the KUnit tree, but if it's easier to take
all of these via ALSA or another tree, let me know.

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David


>  tools/testing/kunit/configs/all_tests.config | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config
> index 0393940c706a..13d15bc693fb 100644
> --- a/tools/testing/kunit/configs/all_tests.config
> +++ b/tools/testing/kunit/configs/all_tests.config
> @@ -35,3 +35,7 @@ CONFIG_DAMON_DBGFS=y
>
>  CONFIG_SECURITY=y
>  CONFIG_SECURITY_APPARMOR=y
> +
> +CONFIG_SOUND=y
> +CONFIG_SND=y
> +CONFIG_SND_SOC=y
>
> --
> 2.39.2
>
Mark Brown July 18, 2023, 2:03 p.m. UTC | #2
On Tue, Jul 18, 2023 at 05:03:41PM +0800, David Gow wrote:

> I'm happy to take this via the KUnit tree, but if it's easier to take
> all of these via ALSA or another tree, let me know.

I was hoping to do a bit more KUnit coverage for ASoC so it'd be kind of
handy to have them in the ASoC tree to make life easier there, though
it's an open question if I actually get round to doing that before the
next merge window.  It looks like everyone is OK with me applying them
so I'll queue them for my CI, please shout if that's an issue.
diff mbox series

Patch

diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config
index 0393940c706a..13d15bc693fb 100644
--- a/tools/testing/kunit/configs/all_tests.config
+++ b/tools/testing/kunit/configs/all_tests.config
@@ -35,3 +35,7 @@  CONFIG_DAMON_DBGFS=y
 
 CONFIG_SECURITY=y
 CONFIG_SECURITY_APPARMOR=y
+
+CONFIG_SOUND=y
+CONFIG_SND=y
+CONFIG_SND_SOC=y