From patchwork Wed Jul 19 05:11:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Ming X-Patchwork-Id: 13318473 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3942BC04E69 for ; Wed, 19 Jul 2023 07:36:32 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E9470201; Wed, 19 Jul 2023 09:35:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E9470201 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1689752191; bh=uoWuUnVVl8lUCX0gLLaVUfClSJyrGloL6ya0FvkjM/k=; h=From:To:CC:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=uv9d6L4KOapbTknZjvTw61leWrL5UbxlmBvfWvG9YVUxgnD7ItGPqYcjUp1otAjJk 6snggSVxmI6uVv+kbXpMXjm8KJy+kPchXby9wF7IDWKNhfztsRA+5i2czLpr8Aldu6 XEJz63AVIsftZnOWDDSkJrD24vKcsCpCMk0XaBCg= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 921AEF8047D; Wed, 19 Jul 2023 09:35:08 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id A32DAF8047D; Wed, 19 Jul 2023 09:35:07 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 00088F8047D; Wed, 19 Jul 2023 07:11:18 +0200 (CEST) Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2070a.outbound.protection.outlook.com [IPv6:2a01:111:f400:feae::70a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E8017F80153 for ; Wed, 19 Jul 2023 07:11:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E8017F80153 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=vivo.com header.i=@vivo.com header.a=rsa-sha256 header.s=selector2 header.b=H8KgYzou ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UiVri3//F4QC1eGI0ENKTPzLsjDQixqoVjew9IrZxhWLXPqZa+ObnvFV8zVPaMehhHfwcR23H5Emu7ViB9hb/82DMqUH3vOpYJhcH0+O5D5WKus1wKQbAntaUYygEZ5IVk/xF2t4zPQSpzzL2NBBrSVmlpkelDw6iN+0cEZpLjrqgj4cTOkVvdeBba7Ojq853TbnW+SxUN2F0lQBnh3jSRr5FN77bl908cwd4CqK3zMl1p7YoGHD8f038SE4bYcbTTb5yPbRkuT9tbTqn6ZczAsWlm+LWQrpE97teDvm0VqvuGmguZyFjVESioIlCOVOXW7+mGyP1b/aBh0/jw2gPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uoWuUnVVl8lUCX0gLLaVUfClSJyrGloL6ya0FvkjM/k=; b=ZrDijd8Bd6itPS2BNfdaqpXdTWTly7aVc8awYWihOyjMzDkavFdCXYFO5ZMqFz4du+fLNCEOntS1xjUlwacFEgCqsSl3LySbT+pqU40wkMdaUaeY4jJmJ8fZunCyoOOETkknvnphuDTRJuLSG7hOHyMFl4IkkoyMoOe3cGGZ5wHOWcvjX2VIqHTAQ26qm1xEaQCAsYgJjLenmMOKl55HhlfTIcMe0IlPBoQND4E7l29oX5AMP7gJLOCNW3/SZ52Sqt7V254JZakIaRZzt3x1tpJcrxO0agP08NLg+PL2lzxEdfE753Gbi69t0FTBdgg9jYG1HDNoZLOiFN+yQKK4QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uoWuUnVVl8lUCX0gLLaVUfClSJyrGloL6ya0FvkjM/k=; b=H8KgYzoucx+X+RU3n/L7TLuwKPTXsCqbwPNMo0OL8RclW0qxzqknqq6Mjf563M0+GOs+69FmaBll8iwmzSxybFTKlFrQzHoPfDdxhHGGWK3/p3lcCO5QA1id33c6ln2YnxKl77VCCoRf5hlfjmFEvvLRWBGfpUjgE4QB64ENEcT1oYoNg3JpjaKJ/5GJv7Hvbx6HniYcZ17wFRdoTF4mwXO6XmlZYBwwi4mnY/SQh3cZ8o9ZgnHYxw/tZ2SvoA+43Sx+Bv5IDMGvlSj2325FIoLN5GqichIuESwWm9H++e+8Zxs5Qpsp4NJf2n7Xc/C/KzKaCOrOyocKs79PHW82Tg== Received: from SG2PR06MB3743.apcprd06.prod.outlook.com (2603:1096:4:d0::18) by TYZPR06MB4190.apcprd06.prod.outlook.com (2603:1096:400:2d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.23; Wed, 19 Jul 2023 05:11:00 +0000 Received: from SG2PR06MB3743.apcprd06.prod.outlook.com ([fe80::535e:25af:a3bc:d600]) by SG2PR06MB3743.apcprd06.prod.outlook.com ([fe80::535e:25af:a3bc:d600%4]) with mapi id 15.20.6609.022; Wed, 19 Jul 2023 05:11:00 +0000 From: =?eucgb2312_cn?b?zfXD9y3I7bz+tdey47y8yvWyvw==?= To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Srinivas Kandagatla , "linux-arm-msm@vger.kernel.org" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" CC: opensource.kernel , =?eucgb2312_cn?b?zfXD9y3I7bz+?= =?eucgb2312_cn?b?tdey47y8yvWyvw==?= Subject: [PATCH v1] slimbus: Use dev_err_probe instead of dev_err Thread-Topic: [PATCH v1] slimbus: Use dev_err_probe instead of dev_err Thread-Index: Adm5/2iP9hPDCwp270Km/EPTvXx3DQ== Date: Wed, 19 Jul 2023 05:11:00 +0000 Message-ID: <20230719051049.4018-1-machel@vivo.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: TYAPR01CA0219.jpnprd01.prod.outlook.com (2603:1096:404:11e::15) To SG2PR06MB3743.apcprd06.prod.outlook.com (2603:1096:4:d0::18) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SG2PR06MB3743:EE_|TYZPR06MB4190:EE_ x-ms-office365-filtering-correlation-id: 68ff3ee8-b1d1-401e-198c-08db88168b0a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U4vqDD7nEcbXaGl+Bv2So+IUDprAkC6lIlqM+eCln+Z3Zv5PitQucmHNb1BqS4XWy1mEbnTTzjGtWvuGpiHN1jhqUdwlqXHS3X+gVrfeb9pzOReSgvKoEJIWcM+yMAZKDZi4BlTFOU3AIRZx5L72+L+BAyCzyN3Tzk6jL78aKd1ed8dyofoQuJzcua3GSvmbIpB2TL1IzmSVDH3KxsqDomj06DTN1izwSQZcv6fI1jK1WdnfhTQWAmbwSZRkwaq/mgh7RRo3SrAOu5lKfUbbyvMKbEl48TCknFs+IyWPQ7u1RRC8znIG5g9V2qt7yKo/TB1GokoDKOLHpqF3RCoENkHJZYuwEP25ZzU3PEOcs6Fs+AE5TgS4ieWFEii/AHJMun6+/3d1Rj3UROzklaOJJvI5T7TeaC7f1lsQ6RVapefgTuoVZ/ezPTS3nCqoWtm0BMjBj+r0bBUs3thQNEZy1z9S2jIizck5JDomVjbbjdSzInq0+4EhGX8RIYRVZBF0sr65vyNYkuhjxkOFTH0/GcYqeKW9x0jEyk7Q1u0DMLaE8LtlZId84zv6aSK9yXeAqwjYoymsajb/rh60bFF11i4XN/B/h7XgWQiaWmHjqwCIv+krjV5sFZvTaVwIeYof x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SG2PR06MB3743.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(366004)(39850400004)(136003)(346002)(451199021)(1076003)(54906003)(122000001)(110136005)(478600001)(6506007)(26005)(107886003)(186003)(71200400001)(52116002)(6486002)(66556008)(4326008)(66446008)(64756008)(66476007)(66946007)(83380400001)(2616005)(6512007)(38350700002)(38100700002)(5660300002)(41300700001)(2906002)(316002)(8936002)(8676002)(86362001)(85182001)(36756003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?eucgb2312_cn?b?MUJ3QWZxMjdxbHVvMmpsYVo5?= =?eucgb2312_cn?b?MWljVFZRV3g5Y05xajhDQW1mbnU3Q3B1dkV6OEFwK1VMWSt6eXpUQ2N5N0llNENn?= =?eucgb2312_cn?b?OUw0VU42a1Fib2VWYzc0WXI3dlRBR1IyRWoyK3ZjclhvQnpuZjNGdWlCUTBXV2lB?= =?eucgb2312_cn?b?TlozYmdlYlVWNXU4d2U0ZWRkMXNHTUF5QldwLzdPTTh4clNPbjE0Y3dzU0wyRy9k?= =?eucgb2312_cn?b?Z1AxU3REUWszdGoyM1BhdTJCZHEvajBQZXNhM0J6MUhBajJ4UW13UXFaV29mZXhx?= =?eucgb2312_cn?b?VVR3V3l2TGpYT0NoOW10aUdUaUgvcHZ3M3gybnJLVFg1NnBCd05neS9McFlIam9p?= =?eucgb2312_cn?b?VityY2R6NEMzdzZFKzMwY3Y2aENwbjI5WituSi9OeWpTZTBPUW8zZ2hpUXRmeXI1?= =?eucgb2312_cn?b?SjdQV20xN2lQekwzaUx5Q3J3a29sbGROMUphTnJIWDh1M0ZlRHE3MDJNeXNXTXJP?= =?eucgb2312_cn?b?SE9zQ0IvckdQSExoT2dBQklLYXBGVUVkaUhOOWlPSTdhdys4YUs2VzBYQ2dia0ZI?= =?eucgb2312_cn?b?M2Z2ZTZjTjExcExxTTBLbVd5QVAwV045MEhZUGUydWxmVVJFTlJzOHE3Z1NjSW1S?= =?eucgb2312_cn?b?SHZPbXBlUkowTE1td2JnVTlmOXlkQ0JQRCtTOTVkSUdGdXN1TVRiRU1EMGhGRzRE?= =?eucgb2312_cn?b?Uytvai8rRHduSlVoSXlyclp0MDFxeVJVdnZPQlg1NEZYa25keWxUUFJwSWg1Zmg4?= =?eucgb2312_cn?b?akN0U2E2UFRtckxnaEk4QUNHQWNldUFUVktmMHN1TXFEMHdoWGkzbUI4OXUvSjNo?= =?eucgb2312_cn?b?dWJFaGY1cjVvVGJ2azh0RzNkVExzRnp3UGsvSm4vL0gwODRvbjlVdUZRRVNGcmpz?= =?eucgb2312_cn?b?My9ObHZpRFEyZys0TktyUk1JWWNjMVVJaTNpQ2g3a0FLMHBrSGxDNUpPcFQ4NDBm?= =?eucgb2312_cn?b?d0xtak13dlBMaWdzYzFKVi9COVJESUswQmJVWHk0KzRmd1BLblIzdWxpNk1WMUgx?= =?eucgb2312_cn?b?N3VCejFzczI2WFhKMG42UE9aMXhCK3JYNFVOSTd0VXNDL0FobGpmbmk0K0hibDZ0?= =?eucgb2312_cn?b?akhERzM3Vy9Oc2VjWUNzWXNDQXFZc01hemg3ZEtWUUQ5OU1jaTdsdXBRRkZNR0xP?= =?eucgb2312_cn?b?WmVWK1dNcEp4NnltMDVHL0FmYklHSGNVYU9MUjAxRWptUFhwK3BtemhZSW5ucG82?= =?eucgb2312_cn?b?aytxaDk0VGRhVkE0MkpuOXhROHpuaXljd08xbTRqSGh6VWdFK1JoV1FTTVpWQyt5?= =?eucgb2312_cn?b?VVlKb3Fkd1pBUkRvOW9PclNhS05hUzFTZ0p1QVNKRFZLNjBnK0g0RTRpQ041enlj?= =?eucgb2312_cn?b?a042T01Ga3Q1Wi9TbnRySWlZeVl6a1dZb0prUEliZ2ZudkEyR3VLZ29yQTNyZzdr?= =?eucgb2312_cn?b?VjVwS2gxYTZkRzFhZ0loRXJRSTZxMWh0ZWpSemNsUDVwVDltcDhjKzh5aitVWk9F?= =?eucgb2312_cn?b?RXpoUGtwckJDSURKNnhkLzloMUQ3SHUrQWo4am5KazBDOUdpZU1IVHkyRjVQK3NR?= =?eucgb2312_cn?b?ZnhyOHJKdzdHUVgvWmxMSU5zTzJaZXBBM29aNjFIczBCNnFxL3JmeUI3eDVyK2pu?= =?eucgb2312_cn?b?Rmlrd1o3bVRyTlJUQjZ0NFkvS1JuWUVFZC9yU3NvWjl0aDVJM01PeEpidUthZHI1?= =?eucgb2312_cn?b?R3pSbXVuN2IwUG55OWM3M2tpaFRKRjlVSko2clVmREhWbGlRRkNuQWE5TGxZaUMz?= =?eucgb2312_cn?b?ci9SRjVFNmEvbU5CM2Vyd1dIMnhaZ1VJemNTVzlrMGRaSUE0VDBoVFNUYlp4Q1VB?= =?eucgb2312_cn?b?ZU1wK1NJYlhUeFF3UDhGT3ViUTNZNkprazM4VllEdzZldE1ZMkdvUGFFZDExK2ZN?= =?eucgb2312_cn?b?VUo3NlZLSHNMSEdMSkV0RkczQUtVTFVZYVRwaG9mQ211VHV6M09JRktvZE1CQWtW?= =?eucgb2312_cn?b?cFVUZ0UzZTdMaVhEcU1lalhqOEkwZW84NTM4eklTd2J4TjE2VjdWZ214cE9aMU91?= =?eucgb2312_cn?b?bnlmZnN6UWtHUEp3RWZRekQxWm8vaG9JQ0l0ZDlac2MrM1o1NHV1eUQyR0ZSU3Nw?= =?eucgb2312_cn?b?Q1l5ellKYTQ5R0hLVnZ2L0YzMno2dHFQdkxwNjZxOU5RcFpxeXdMU3J4ZGJIZkdI?= =?eucgb2312_cn?b?aXVzVFVHNmJjNG5EdkZTdjdGaS8rTWMzUzRNK2FkZ1VmUzJHTW91UXdVV3ZzLw==?= MIME-Version: 1.0 X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68ff3ee8-b1d1-401e-198c-08db88168b0a X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2023 05:11:00.6210 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G8dArpLx5wxBFoESosPUjnXnDUQD7GOMjeqbVisdPNh2sZe6FEBue1jtxUsoh7JBNEDnOPK9mpF+4trupQWhfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4190 X-MailFrom: machel@vivo.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: ECWMCRU5HJJS3GSFDCIQB53OTFHZGMAK X-Message-ID-Hash: ECWMCRU5HJJS3GSFDCIQB53OTFHZGMAK X-Mailman-Approved-At: Wed, 19 Jul 2023 07:35:01 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: It is possible that dma_request_chan will return EPROBE_DEFER, which means that dev is not ready yet. In this case, dev_err(dev), there will be no output. This patch fixes the bug. Signed-off-by: Wang Ming --- drivers/slimbus/qcom-ngd-ctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 77aa6d26476c..d5c2a732f63f 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -679,8 +679,8 @@ static int qcom_slim_ngd_init_rx_msgq(struct qcom_slim_ngd_ctrl *ctrl) ctrl->dma_rx_channel = dma_request_chan(dev, "rx"); if (IS_ERR(ctrl->dma_rx_channel)) { - dev_err(dev, "Failed to request RX dma channel"); - ret = PTR_ERR(ctrl->dma_rx_channel); + ret = dev_err_probe(dev, PTR_ERR(ctrl->dma_rx_channel), + "Failed to request RX dma channel"); ctrl->dma_rx_channel = NULL; return ret; } @@ -717,8 +717,8 @@ static int qcom_slim_ngd_init_tx_msgq(struct qcom_slim_ngd_ctrl *ctrl) ctrl->dma_tx_channel = dma_request_chan(dev, "tx"); if (IS_ERR(ctrl->dma_tx_channel)) { - dev_err(dev, "Failed to request TX dma channel"); - ret = PTR_ERR(ctrl->dma_tx_channel); + ret = dev_err_probe(dev, PTR_ERR(ctrl->dma_tx_channel), + "Failed to request TX dma channel"); ctrl->dma_tx_channel = NULL; return ret; }