| Message ID | 20230810114738.2103792-3-lizetao1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 29681184da28babc990a66e197d27ab98f2027af |
| Headers | show |
| Series | Use devm_kmemdup to replace devm_kmalloc + memcpy | expand |
On Thu, 10 Aug 2023 19:47:38 +0800 Li Zetao <lizetao1@huawei.com> wrote: > Use the helper function devm_kmemdup() rather than duplicating its > implementation, which helps to enhance code readability. > > Signed-off-by: Li Zetao <lizetao1@huawei.com> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
diff --git a/sound/soc/sof/ipc3.c b/sound/soc/sof/ipc3.c index 33df028d4854..fb40378ad084 100644 --- a/sound/soc/sof/ipc3.c +++ b/sound/soc/sof/ipc3.c @@ -567,13 +567,10 @@ int sof_ipc3_get_cc_info(struct snd_sof_dev *sdev, /* create read-only cc_version debugfs to store compiler version info */ /* use local copy of the cc_version to prevent data corruption */ if (sdev->first_boot) { - sdev->cc_version = devm_kmalloc(sdev->dev, cc->ext_hdr.hdr.size, - GFP_KERNEL); - + sdev->cc_version = devm_kmemdup(sdev->dev, cc, cc->ext_hdr.hdr.size, GFP_KERNEL); if (!sdev->cc_version) return -ENOMEM; - memcpy(sdev->cc_version, cc, cc->ext_hdr.hdr.size); ret = snd_sof_debugfs_buf_item(sdev, sdev->cc_version, cc->ext_hdr.hdr.size, "cc_version", 0444);
Use the helper function devm_kmemdup() rather than duplicating its implementation, which helps to enhance code readability. Signed-off-by: Li Zetao <lizetao1@huawei.com> --- sound/soc/sof/ipc3.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)