| Message ID | 20230823-cs42l43_pll_ev-init-ret-v1-1-5836f1ad5dad@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a74048432fbb30e7a574747f6e1f47aef17010b0 |
| Headers | show |
| Series | ASoC: cs42l43: Initialize ret in default case in cs42l43_pll_ev() | expand |
On Wed, 23 Aug 2023 09:32:50 -0700, Nathan Chancellor wrote: > clang warns (or errors with CONFIG_WERROR=y): > > sound/soc/codecs/cs42l43.c:1371:2: error: variable 'ret' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized] > 1371 | default: > | ^~~~~~~ > sound/soc/codecs/cs42l43.c:1377:9: note: uninitialized use occurs here > 1377 | return ret; > | ^~~ > sound/soc/codecs/cs42l43.c:1349:9: note: initialize the variable 'ret' to silence this warning > 1349 | int ret; > | ^ > | = 0 > 1 error generated. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: cs42l43: Initialize ret in default case in cs42l43_pll_ev() commit: a74048432fbb30e7a574747f6e1f47aef17010b0 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c index 55a79219af35..18178ffa82f2 100644 --- a/sound/soc/codecs/cs42l43.c +++ b/sound/soc/codecs/cs42l43.c @@ -1369,6 +1369,7 @@ static int cs42l43_pll_ev(struct snd_soc_dapm_widget *w, clk_disable_unprepare(priv->mclk); break; default: + ret = 0; break; }
clang warns (or errors with CONFIG_WERROR=y): sound/soc/codecs/cs42l43.c:1371:2: error: variable 'ret' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized] 1371 | default: | ^~~~~~~ sound/soc/codecs/cs42l43.c:1377:9: note: uninitialized use occurs here 1377 | return ret; | ^~~ sound/soc/codecs/cs42l43.c:1349:9: note: initialize the variable 'ret' to silence this warning 1349 | int ret; | ^ | = 0 1 error generated. Initialize ret to 0 in the default case, as there was nothing to do for other event types. Closes: https://github.com/ClangBuiltLinux/linux/issues/1922 Fixes: fc918cbe874e ("ASoC: cs42l43: Add support for the cs42l43") Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- sound/soc/codecs/cs42l43.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: 014ee0692f29da8b08fed5da0fa14e04698a50f7 change-id: 20230823-cs42l43_pll_ev-init-ret-fb1e47ea0605 Best regards,