From patchwork Wed Aug 30 19:55:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlad Karpovich X-Patchwork-Id: 13371122 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97CDCC83F10 for ; Thu, 31 Aug 2023 08:28:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BDFCA3E8; Thu, 31 Aug 2023 10:27:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BDFCA3E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1693470529; bh=8q8BvDY0LKXfPAAPyrF61nUvfy0GKUjaHQDUp+AMGu8=; h=From:To:CC:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=EbZhXtgX8FJTqX1cBiZI0bPAz+v6cBMTPZFKk5A/ynBfI/eNn/TFXqNsmxU8dRDpU khhmG2UBTrYLlfP287lDSpeUTz89VSwudzl5iVckj4QRX/FGt2AY9WN/N2KdTUlns0 WANue173RO9OikG4xtBStiGQmRZ9/fKEPSd/elvc= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D00BCF80570; Thu, 31 Aug 2023 10:25:58 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 7A91DF80568; Thu, 31 Aug 2023 10:25:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C3950F80158; Wed, 30 Aug 2023 21:56:22 +0200 (CEST) Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2AAD2F800F5 for ; Wed, 30 Aug 2023 21:56:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2AAD2F800F5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=cirrus.com header.i=@cirrus.com header.a=rsa-sha256 header.s=PODMain02222019 header.b=jaEznPhA Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 37UHsI8m024465; Wed, 30 Aug 2023 14:56:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=8 fD74OlzXGZqtv4t5a4iQJ3l7Jbn7phXIoroy2WVeQM=; b=jaEznPhAaIOi00W2l 2q8g3AmqqX/rzhcpNp+E8C9vgwphSGRnu+KDeL04pJnubnzmjFUA9KIAxajr+bBo gxJQX+kFdRF//3Lk2SXs27lx5llSfzLN6pP6+sK+ifIHW/36m5EBZGrQdCzxXtg0 6CmdYzRYaPUJ/1RG31IQraw0+lZD2qNRxPe3HK7xpTDsdbArZeKRNhD1x3RyZw3e 5M5Nsz3IzEZ58EPHUZtXVd8h7KYFsHo2iLkCjPGx+J1qmNT+PKGBDXygz50wYkGr 34EQ7vqxYN1J38PSYsDItn/sVbSe/wmk7llmD2hUxjev9GX2YfyVlovm1KewEzov A3uRQ== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3sqesydet6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Aug 2023 14:56:03 -0500 (CDT) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Wed, 30 Aug 2023 20:56:00 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Wed, 30 Aug 2023 20:56:00 +0100 Received: from vkarpovich-ThinkStation-P620.crystal.cirrus.com (vkarpovich-ThinkStation-P620.ad.cirrus.com [141.131.145.49]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id AB4D93563; Wed, 30 Aug 2023 19:55:58 +0000 (UTC) From: Vlad Karpovich To: James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring CC: , , , , Vlad Karpovich , Ricardo Rivera-Matos Subject: [PATCH v2 1/4] ASoC: cs35l45: Checks index of cs35l45_irqs[] Date: Wed, 30 Aug 2023 14:55:33 -0500 Message-ID: <20230830195536.448884-1-vkarpovi@opensource.cirrus.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: -D_7bmSqULdL-eadz0hEzmvvZ8ewAy6M X-Proofpoint-GUID: -D_7bmSqULdL-eadz0hEzmvvZ8ewAy6M X-Proofpoint-Spam-Reason: safe X-MailFrom: prvs=4606cf803d=vkarpovi@opensource.cirrus.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: FW7UVF7HC3H7X2EPVVTWZEBI4YNH2XAL X-Message-ID-Hash: FW7UVF7HC3H7X2EPVVTWZEBI4YNH2XAL X-Mailman-Approved-At: Thu, 31 Aug 2023 08:25:54 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Checks the index computed by the virq offset before printing the error condition in cs35l45_spk_safe_err() handler. Signed-off-by: Ricardo Rivera-Matos Signed-off-by: Vlad Karpovich --- sound/soc/codecs/cs35l45.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs35l45.c b/sound/soc/codecs/cs35l45.c index 2ac4612402eb..02b1172d2647 100644 --- a/sound/soc/codecs/cs35l45.c +++ b/sound/soc/codecs/cs35l45.c @@ -1023,7 +1023,10 @@ static irqreturn_t cs35l45_spk_safe_err(int irq, void *data) i = irq - regmap_irq_get_virq(cs35l45->irq_data, 0); - dev_err(cs35l45->dev, "%s condition detected!\n", cs35l45_irqs[i].name); + if (i < 0 || i >= ARRAY_SIZE(cs35l45_irqs)) + dev_err(cs35l45->dev, "Unspecified global error condition (%d) detected!\n", irq); + else + dev_err(cs35l45->dev, "%s condition detected!\n", cs35l45_irqs[i].name); return IRQ_HANDLED; }