diff mbox series

[5/6] ASoC: rt5640: Fix IRQ not being free-ed for HDA jack detect mode

Message ID 20230912113245.320159-6-hdegoede@redhat.com (mailing list archive)
State Accepted
Commit 8c8bf3df6b7c0ed1c4dd373b23eb0ce13a63f452
Headers show
Series ASoC: rt5640: Fix various IRQ handling issues | expand

Commit Message

Hans de Goede Sept. 12, 2023, 11:32 a.m. UTC 
Set "rt5640->irq_requested = true" after a successful request_irq()
in rt5640_enable_hda_jack_detect(), so that rt5640_disable_jack_detect()
properly frees the IRQ.

This fixes the IRQ not being freed on rmmod / driver unbind.

Fixes: 2b9c8d2b3c89 ("ASoC: rt5640: Add the HDA header support")
Cc: Oder Chiou <oder_chiou@realtek.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/soc/codecs/rt5640.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c
index 03c866c04c7a..a4a11407ab10 100644
--- a/sound/soc/codecs/rt5640.c
+++ b/sound/soc/codecs/rt5640.c
@@ -2625,6 +2625,7 @@  static void rt5640_enable_hda_jack_detect(
 		rt5640->jack = NULL;
 		return;
 	}
+	rt5640->irq_requested = true;
 
 	/* sync initial jack state */
 	queue_delayed_work(system_long_wq, &rt5640->jack_work, 0);