| Message ID | 20230921183313.54112-1-bragathemanick0908@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 39fce972fd7259395663586e59388d702afec30e |
| Headers | show |
| Series | [v2] ASoC: dt-bindings: tfa9879: Convert to dtschema | expand |
On Fri, Sep 22, 2023 at 12:03:13AM +0530, Bragatheswaran Manickavel wrote: > Convert the tfa9879 audio CODEC bindings to DT schema > No error/warning seen when running make dt_binding_check > > Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> > Changes: > V1 -> V2: Fixed DT syntax errors and doc warning These should be under the --- line, not above it. Perhaps Mark will change it on application. Otherwise, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > .../bindings/sound/nxp,tfa9879.yaml | 44 +++++++++++++++++++ > .../devicetree/bindings/sound/tfa9879.txt | 23 ---------- > MAINTAINERS | 2 +- > 3 files changed, 45 insertions(+), 24 deletions(-) > create mode 100644 Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml > delete mode 100644 Documentation/devicetree/bindings/sound/tfa9879.txt > > diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml > new file mode 100644 > index 000000000000..df26248573ad > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nxp,tfa9879.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP TFA9879 class-D audio amplifier > + > +maintainers: > + - Peter Rosin <peda@axentia.se> > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + const: nxp,tfa9879 > + > + reg: > + maxItems: 1 > + > + "#sound-dai-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - '#sound-dai-cells' > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c1 { > + #address-cells = <1>; > + #size-cells = <0>; > + amplifier@6c { > + compatible = "nxp,tfa9879"; > + reg = <0x6c>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c1>; > + #sound-dai-cells = <0>; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/sound/tfa9879.txt b/Documentation/devicetree/bindings/sound/tfa9879.txt > deleted file mode 100644 > index 1620e6848436..000000000000 > --- a/Documentation/devicetree/bindings/sound/tfa9879.txt > +++ /dev/null > @@ -1,23 +0,0 @@ > -NXP TFA9879 class-D audio amplifier > - > -Required properties: > - > -- compatible : "nxp,tfa9879" > - > -- reg : the I2C address of the device > - > -- #sound-dai-cells : must be 0. > - > -Example: > - > -&i2c1 { > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_i2c1>; > - > - amp: amp@6c { > - #sound-dai-cells = <0>; > - compatible = "nxp,tfa9879"; > - reg = <0x6c>; > - }; > -}; > - > diff --git a/MAINTAINERS b/MAINTAINERS > index a4c30221eb30..569303daf9b4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15476,7 +15476,7 @@ NXP TFA9879 DRIVER > M: Peter Rosin <peda@axentia.se> > L: alsa-devel@alsa-project.org (moderated for non-subscribers) > S: Maintained > -F: Documentation/devicetree/bindings/sound/tfa9879.txt > +F: Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml > F: sound/soc/codecs/tfa9879* > > NXP-NCI NFC DRIVER > -- > 2.34.1 >
On 22/09/23 20:56, Conor Dooley wrote: > On Fri, Sep 22, 2023 at 12:03:13AM +0530, Bragatheswaran Manickavel wrote: >> Convert the tfa9879 audio CODEC bindings to DT schema >> No error/warning seen when running make dt_binding_check >> >> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> >> Changes: >> V1 -> V2: Fixed DT syntax errors and doc warning > These should be under the --- line, not above it. > Perhaps Mark will change it on application. > Otherwise, > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Thanks, > Conor. Hi Conor, Thanks for reviewing it. Do I need to send a new patch by addressing the above comments ? > >> --- >> .../bindings/sound/nxp,tfa9879.yaml | 44 +++++++++++++++++++ >> .../devicetree/bindings/sound/tfa9879.txt | 23 ---------- >> MAINTAINERS | 2 +- >> 3 files changed, 45 insertions(+), 24 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml >> delete mode 100644 Documentation/devicetree/bindings/sound/tfa9879.txt >> >> diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml >> new file mode 100644 >> index 000000000000..df26248573ad >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml >> @@ -0,0 +1,44 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/nxp,tfa9879.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NXP TFA9879 class-D audio amplifier >> + >> +maintainers: >> + - Peter Rosin <peda@axentia.se> >> + >> +allOf: >> + - $ref: dai-common.yaml# >> + >> +properties: >> + compatible: >> + const: nxp,tfa9879 >> + >> + reg: >> + maxItems: 1 >> + >> + "#sound-dai-cells": >> + const: 0 >> + >> +required: >> + - compatible >> + - reg >> + - '#sound-dai-cells' >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + i2c1 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + amplifier@6c { >> + compatible = "nxp,tfa9879"; >> + reg = <0x6c>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2c1>; >> + #sound-dai-cells = <0>; >> + }; >> + }; >> diff --git a/Documentation/devicetree/bindings/sound/tfa9879.txt b/Documentation/devicetree/bindings/sound/tfa9879.txt >> deleted file mode 100644 >> index 1620e6848436..000000000000 >> --- a/Documentation/devicetree/bindings/sound/tfa9879.txt >> +++ /dev/null >> @@ -1,23 +0,0 @@ >> -NXP TFA9879 class-D audio amplifier >> - >> -Required properties: >> - >> -- compatible : "nxp,tfa9879" >> - >> -- reg : the I2C address of the device >> - >> -- #sound-dai-cells : must be 0. >> - >> -Example: >> - >> -&i2c1 { >> - pinctrl-names = "default"; >> - pinctrl-0 = <&pinctrl_i2c1>; >> - >> - amp: amp@6c { >> - #sound-dai-cells = <0>; >> - compatible = "nxp,tfa9879"; >> - reg = <0x6c>; >> - }; >> -}; >> - >> diff --git a/MAINTAINERS b/MAINTAINERS >> index a4c30221eb30..569303daf9b4 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -15476,7 +15476,7 @@ NXP TFA9879 DRIVER >> M: Peter Rosin <peda@axentia.se> >> L: alsa-devel@alsa-project.org (moderated for non-subscribers) >> S: Maintained >> -F: Documentation/devicetree/bindings/sound/tfa9879.txt >> +F: Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml >> F: sound/soc/codecs/tfa9879* >> >> NXP-NCI NFC DRIVER >> -- >> 2.34.1 >>
On Fri, Sep 22, 2023 at 10:53:06PM +0530, Bragatheswaran Manickavel wrote: > > On 22/09/23 20:56, Conor Dooley wrote: > > On Fri, Sep 22, 2023 at 12:03:13AM +0530, Bragatheswaran Manickavel wrote: > > > Convert the tfa9879 audio CODEC bindings to DT schema > > > No error/warning seen when running make dt_binding_check > > > > > > Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> > > > Changes: > > > V1 -> V2: Fixed DT syntax errors and doc warning > > These should be under the --- line, not above it. > > Perhaps Mark will change it on application. > > Otherwise, > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Thanks for reviewing it. > Do I need to send a new patch by addressing the above comments ? To be clear, it's the changelog, not the sign off, that needs to go under the ---. It'd look like: Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> --- Changes: V1 -> V2: Fixed DT syntax errors and doc warning Mark often fixes these things when he applies patches, but sending a v2 w/ the changelog fixed might make his life easier. Cheers, Conor.
On Fri, 22 Sep 2023 00:03:13 +0530, Bragatheswaran Manickavel wrote: > Convert the tfa9879 audio CODEC bindings to DT schema > No error/warning seen when running make dt_binding_check > > Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> > > Changes: > V1 -> V2: Fixed DT syntax errors and doc warning > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: dt-bindings: tfa9879: Convert to dtschema commit: 39fce972fd7259395663586e59388d702afec30e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml new file mode 100644 index 000000000000..df26248573ad --- /dev/null +++ b/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/nxp,tfa9879.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP TFA9879 class-D audio amplifier + +maintainers: + - Peter Rosin <peda@axentia.se> + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + const: nxp,tfa9879 + + reg: + maxItems: 1 + + "#sound-dai-cells": + const: 0 + +required: + - compatible + - reg + - '#sound-dai-cells' + +unevaluatedProperties: false + +examples: + - | + i2c1 { + #address-cells = <1>; + #size-cells = <0>; + amplifier@6c { + compatible = "nxp,tfa9879"; + reg = <0x6c>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c1>; + #sound-dai-cells = <0>; + }; + }; diff --git a/Documentation/devicetree/bindings/sound/tfa9879.txt b/Documentation/devicetree/bindings/sound/tfa9879.txt deleted file mode 100644 index 1620e6848436..000000000000 --- a/Documentation/devicetree/bindings/sound/tfa9879.txt +++ /dev/null @@ -1,23 +0,0 @@ -NXP TFA9879 class-D audio amplifier - -Required properties: - -- compatible : "nxp,tfa9879" - -- reg : the I2C address of the device - -- #sound-dai-cells : must be 0. - -Example: - -&i2c1 { - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_i2c1>; - - amp: amp@6c { - #sound-dai-cells = <0>; - compatible = "nxp,tfa9879"; - reg = <0x6c>; - }; -}; - diff --git a/MAINTAINERS b/MAINTAINERS index a4c30221eb30..569303daf9b4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15476,7 +15476,7 @@ NXP TFA9879 DRIVER M: Peter Rosin <peda@axentia.se> L: alsa-devel@alsa-project.org (moderated for non-subscribers) S: Maintained -F: Documentation/devicetree/bindings/sound/tfa9879.txt +F: Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml F: sound/soc/codecs/tfa9879* NXP-NCI NFC DRIVER
Convert the tfa9879 audio CODEC bindings to DT schema No error/warning seen when running make dt_binding_check Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> Changes: V1 -> V2: Fixed DT syntax errors and doc warning --- .../bindings/sound/nxp,tfa9879.yaml | 44 +++++++++++++++++++ .../devicetree/bindings/sound/tfa9879.txt | 23 ---------- MAINTAINERS | 2 +- 3 files changed, 45 insertions(+), 24 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml delete mode 100644 Documentation/devicetree/bindings/sound/tfa9879.txt