diff mbox series

soundwire: Use snd_soc_substream_to_rtd() to obtain rtd

Message ID 20230929105546.774332-1-amadeuszx.slawinski@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series soundwire: Use snd_soc_substream_to_rtd() to obtain rtd | expand

Commit Message

Amadeusz Sławiński Sept. 29, 2023, 10:55 a.m. UTC
From: Cezary Rojewski <cezary.rojewski@intel.com>

Utilize the helper function instead of casting from ->private_data
directly.

Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
---
 drivers/soundwire/stream.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Vinod Koul Oct. 16, 2023, 11:20 a.m. UTC | #1
On 29-09-23, 12:55, Amadeusz Sławiński wrote:
> From: Cezary Rojewski <cezary.rojewski@intel.com>
> 
> Utilize the helper function instead of casting from ->private_data
> directly.
> 
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
> ---
>  drivers/soundwire/stream.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
> index 69719b335bcb..652aae4e221d 100644
> --- a/drivers/soundwire/stream.c
> +++ b/drivers/soundwire/stream.c
> @@ -1717,7 +1717,7 @@ EXPORT_SYMBOL(sdw_deprepare_stream);
>  static int set_stream(struct snd_pcm_substream *substream,
>  		      struct sdw_stream_runtime *sdw_stream)
>  {
> -	struct snd_soc_pcm_runtime *rtd = substream->private_data;
> +	struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);

This does not exist for me, so I guess you can resend it after next
cycle when this appears in rc1
Vinod Koul March 3, 2024, 2:01 p.m. UTC | #2
On Fri, 29 Sep 2023 12:55:46 +0200, Amadeusz Sławiński wrote:
> Utilize the helper function instead of casting from ->private_data
> directly.
> 
> 

Applied, thanks!

[1/1] soundwire: Use snd_soc_substream_to_rtd() to obtain rtd
      commit: e17aae16acf53938deb4b7702aa4f6cee2c4a073

Best regards,
diff mbox series

Patch

diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
index 69719b335bcb..652aae4e221d 100644
--- a/drivers/soundwire/stream.c
+++ b/drivers/soundwire/stream.c
@@ -1717,7 +1717,7 @@  EXPORT_SYMBOL(sdw_deprepare_stream);
 static int set_stream(struct snd_pcm_substream *substream,
 		      struct sdw_stream_runtime *sdw_stream)
 {
-	struct snd_soc_pcm_runtime *rtd = substream->private_data;
+	struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
 	struct snd_soc_dai *dai;
 	int ret = 0;
 	int i;
@@ -1770,7 +1770,7 @@  EXPORT_SYMBOL(sdw_alloc_stream);
 int sdw_startup_stream(void *sdw_substream)
 {
 	struct snd_pcm_substream *substream = sdw_substream;
-	struct snd_soc_pcm_runtime *rtd = substream->private_data;
+	struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
 	struct sdw_stream_runtime *sdw_stream;
 	char *name;
 	int ret;
@@ -1814,7 +1814,7 @@  EXPORT_SYMBOL(sdw_startup_stream);
 void sdw_shutdown_stream(void *sdw_substream)
 {
 	struct snd_pcm_substream *substream = sdw_substream;
-	struct snd_soc_pcm_runtime *rtd = substream->private_data;
+	struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
 	struct sdw_stream_runtime *sdw_stream;
 	struct snd_soc_dai *dai;