From patchwork Mon Oct 2 12:50:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 13406214 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66172E784AC for ; Mon, 2 Oct 2023 12:52:46 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 782B9E0F; Mon, 2 Oct 2023 14:51:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 782B9E0F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1696251163; bh=BtDQpejOQikwr58mthrCyuEMXL/exHGCVHq0uqHYjvY=; h=From:To:CC:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=OBcF6eI2rqRoA8ZzEW4W/Dzs/ILo8/AnQHx2gqhjw4DOtwW9RpjaqxYi39jmKMqO5 m/xf5bIVPgFEwOIE5EqiASPSc4jhkH7UVKy7ikT6Qk/L9ckToArYkni/ONBS9FlZNF kVy4nv2yTTIUmkcEWNdCp535APu37ck2mfN5Bn/o= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 016FAF80551; Mon, 2 Oct 2023 14:51:32 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id A2ABFF80549; Mon, 2 Oct 2023 14:51:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 47056F80310; Mon, 2 Oct 2023 14:51:27 +0200 (CEST) Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4C599F80166 for ; Mon, 2 Oct 2023 14:51:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4C599F80166 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=cirrus.com header.i=@cirrus.com header.a=rsa-sha256 header.s=PODMain02222019 header.b=Z+4B7QxW Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 3926VdoF031278; Mon, 2 Oct 2023 07:51:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=W j4F+bHn9pzMOzyfsWKN+qDwvvtBojn1C4VrichB830=; b=Z+4B7QxW3O+5r0D20 RXAuYgp7xfEdj6x0LSOwdKWBdBdi58oBiXsq5DEp3yKdYNv9N0M494I/UyJjtlKp 5aFefbLHjFF+2x4yG5gngZCN895MgEeYY2QF9GGXlwCE+uD4tceDNvd/Of7cM4Mm WBi6u97mBXpDqG9AG86w2nB1NWm+ZXi73vlRId69I3SnkhySK9MxxvqandBXp8Y3 x9J640ZE9pEW2nnR5P6V6cb69aDYSdzhDFrrIIWLVsOQIqDw1f/qHkIhJK/MFfs+ n/zR0RMaTUw/S/0WH0p3xMvRjg25wMgBBnnIpCNhdrESg+z4JUp87vnKK+RVdpPg vllDw== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3teh2xtv0w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Oct 2023 07:51:02 -0500 (CDT) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Mon, 2 Oct 2023 13:51:00 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Mon, 2 Oct 2023 13:51:00 +0100 Received: from edi-sw-dsktp-006.ad.cirrus.com (edi-sw-dsktp-006.ad.cirrus.com [198.90.251.13]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id DC63FB2F; Mon, 2 Oct 2023 12:50:59 +0000 (UTC) From: Richard Fitzgerald To: CC: , , , Richard Fitzgerald Subject: [PATCH 6.5] ASoC: cs35l56: Call pm_runtime_dont_use_autosuspend() Date: Mon, 2 Oct 2023 13:50:59 +0100 Message-ID: <20231002125059.4091982-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Proofpoint-GUID: xm7Z10fTc1btYr-LSqioz1irOK1SGnBg X-Proofpoint-ORIG-GUID: xm7Z10fTc1btYr-LSqioz1irOK1SGnBg X-Proofpoint-Spam-Reason: safe Message-ID-Hash: B26VLVPWX236JPO4WXRC5UFHGB5PIKZR X-Message-ID-Hash: B26VLVPWX236JPO4WXRC5UFHGB5PIKZR X-MailFrom: prvs=5639ea291d=rf@opensource.cirrus.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: commit ec03804552e9a723569e14d2512f36a8e70dc640 upstream Driver remove() must call pm_runtime_dont_use_autosuspend(). Drivers that call pm_runtime_use_autosuspend() must disable it in driver remove(). Unfortunately until recently this was only mentioned in 1 line in a 900+ line document so most people hadn't noticed this. It has only recently been added to the kerneldoc of pm_runtime_use_autosuspend(). Backport note: This is the same change as the upstream commit but the cs35l56->base.dev argument in the upstream code is cs35l56->dev in older releases. Signed-off-by: Richard Fitzgerald Link: https://lore.kernel.org/r/20230908101716.2658582-1-rf@opensource.cirrus.com Signed-off-by: Mark Brown --- Please apply to 6.5. --- sound/soc/codecs/cs35l56.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c index fd06b9f9d496..7e241908b5f1 100644 --- a/sound/soc/codecs/cs35l56.c +++ b/sound/soc/codecs/cs35l56.c @@ -1594,6 +1594,7 @@ void cs35l56_remove(struct cs35l56_private *cs35l56) flush_workqueue(cs35l56->dsp_wq); destroy_workqueue(cs35l56->dsp_wq); + pm_runtime_dont_use_autosuspend(cs35l56->dev); pm_runtime_suspend(cs35l56->dev); pm_runtime_disable(cs35l56->dev);