diff mbox series

[RESEND] ALSA: hda: cs35l56: Enable low-power hibernation mode on i2c

Message ID 20231113164029.1156669-1-rf@opensource.cirrus.com (mailing list archive)
State Accepted
Commit d02ef87db9d6137fc2a98231b92f24ead4f7966d
Headers show
Series [RESEND] ALSA: hda: cs35l56: Enable low-power hibernation mode on i2c | expand

Commit Message

Richard Fitzgerald Nov. 13, 2023, 4:40 p.m. UTC 
From: Simon Trimmer <simont@opensource.cirrus.com>

This can now be re-enabled as the sequence to reliably wake the device
has been implemented in the shared ASoC code.

This has a functional dependency on commit 3df761bdbc8b
("ASoC: cs35l56: Wake transactions need to be issued twice")

To protect against this, enabling hibernation is conditional on
CS35L56_WAKE_HOLD_TIME_US being defined, which indicates that the new
hibernation sequences are available.

Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
 sound/pci/hda/cs35l56_hda_i2c.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Takashi Iwai Nov. 14, 2023, 1:10 p.m. UTC | #1 
On Mon, 13 Nov 2023 17:40:29 +0100,
Richard Fitzgerald wrote:
> 
> From: Simon Trimmer <simont@opensource.cirrus.com>
> 
> This can now be re-enabled as the sequence to reliably wake the device
> has been implemented in the shared ASoC code.
> 
> This has a functional dependency on commit 3df761bdbc8b
> ("ASoC: cs35l56: Wake transactions need to be issued twice")
> 
> To protect against this, enabling hibernation is conditional on
> CS35L56_WAKE_HOLD_TIME_US being defined, which indicates that the new
> hibernation sequences are available.
> 
> Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>

Thanks, applied.


Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/cs35l56_hda_i2c.c b/sound/pci/hda/cs35l56_hda_i2c.c
index 757a4d193e0f..a9ef6d86de83 100644
--- a/sound/pci/hda/cs35l56_hda_i2c.c
+++ b/sound/pci/hda/cs35l56_hda_i2c.c
@@ -21,6 +21,10 @@  static int cs35l56_hda_i2c_probe(struct i2c_client *clt)
 		return -ENOMEM;
 
 	cs35l56->base.dev = &clt->dev;
+
+#ifdef CS35L56_WAKE_HOLD_TIME_US
+	cs35l56->base.can_hibernate = true;
+#endif
 	cs35l56->base.regmap = devm_regmap_init_i2c(clt, &cs35l56_regmap_i2c);
 	if (IS_ERR(cs35l56->base.regmap)) {
 		ret = PTR_ERR(cs35l56->base.regmap);