| Message ID | 20231205220131.2585913-1-cujomalainey@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d20d36755a605a21e737b6b16c566658589b1811 |
| Headers | show |
| Series | ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible | expand |
On Tue, Dec 05, 2023 at 02:01:18PM -0800, cujomalainey@chromium.org wrote: > From: Curtis Malainey <cujomalainey@chromium.org> > > This reverts commit 505c83212da5bfca95109421b8f5d9f8c6cdfef2. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone. Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.
Il 05/12/23 23:01, cujomalainey@chromium.org ha scritto: > From: Curtis Malainey <cujomalainey@chromium.org> > > This reverts commit 505c83212da5bfca95109421b8f5d9f8c6cdfef2. > > This is not an official topology from the SOF project. Topologies are > named based on the card configuration and are NOT board specific. > While I can totally agree with that, can you please explain how should the correct topology file name be selected instead of machine compatibles? Thanks, Angelo
On Wed, Dec 6, 2023 at 6:32 AM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 05/12/23 23:01, cujomalainey@chromium.org ha scritto: > > From: Curtis Malainey <cujomalainey@chromium.org> > > > > This reverts commit 505c83212da5bfca95109421b8f5d9f8c6cdfef2. > > > > This is not an official topology from the SOF project. Topologies are > > named based on the card configuration and are NOT board specific. > > > > While I can totally agree with that, can you please explain how should the correct > topology file name be selected instead of machine compatibles? > > Thanks, > Angelo The typical convention is if there is more than one configuration with an SoC to suffix with the components involved. Additional suffixes can be added for special cases e.g. for Intel sof-tgl-rt5682-max98357a.tplg where tgl is the SoC family, rt5682 is the codec and max98357a is the amp. You can find examples where the pin mapping was changed accidentally on some boards so you will see suffixes like "-up4". Public suffixes/topologies do not include 3P blocks. Curtis >
On Wed, Dec 6, 2023 at 6:21 AM Mark Brown <broonie@kernel.org> wrote: > > On Tue, Dec 05, 2023 at 02:01:18PM -0800, cujomalainey@chromium.org wrote: > > From: Curtis Malainey <cujomalainey@chromium.org> > > > > This reverts commit 505c83212da5bfca95109421b8f5d9f8c6cdfef2. > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. Apologies, here is a user friendly summary ASoC: SOF: mediatek: mt8186: Revert "ASoC: SOF: mediatek: mt8186: Add Google Steelix topology compatible"
On Tue, 05 Dec 2023 14:01:18 -0800, cujomalainey@chromium.org wrote: > This reverts commit 505c83212da5bfca95109421b8f5d9f8c6cdfef2. > > This is not an official topology from the SOF project. Topologies are > named based on the card configuration and are NOT board specific. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible commit: d20d36755a605a21e737b6b16c566658589b1811 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/sof/mediatek/mt8186/mt8186.c b/sound/soc/sof/mediatek/mt8186/mt8186.c index 1d37c9767986f..0d2d7d697de02 100644 --- a/sound/soc/sof/mediatek/mt8186/mt8186.c +++ b/sound/soc/sof/mediatek/mt8186/mt8186.c @@ -548,9 +548,6 @@ static struct snd_sof_dsp_ops sof_mt8186_ops = { static struct snd_sof_of_mach sof_mt8186_machs[] = { { - .compatible = "google,steelix", - .sof_tplg_filename = "sof-mt8186-google-steelix.tplg" - }, { .compatible = "mediatek,mt8186", .sof_tplg_filename = "sof-mt8186.tplg", },