| Message ID | 20240106162752.18599-1-erick.archer@gmx.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | be69eae9673638583cfcad44c1da6abf91efc4a3 |
| Headers | show |
| Series | ASoC: ti: Use devm_kcalloc() instead of devm_kzalloc() | expand |
On 1/6/24 10:27, Erick Archer wrote: > Use 2-factor multiplication argument form devm_kcalloc() instead > of devm_kzalloc(). > > Link: https://github.com/KSPP/linux/issues/162 > Signed-off-by: Erick Archer <erick.archer@gmx.com> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Thanks!
On 06/01/2024 18:27, Erick Archer wrote: > Use 2-factor multiplication argument form devm_kcalloc() instead > of devm_kzalloc(). > > Link: https://github.com/KSPP/linux/issues/162 > Signed-off-by: Erick Archer <erick.archer@gmx.com> Can you fix the commit title to: ASoC: ti: j721e-evm.: Use devm_kcalloc() instead of devm_kzalloc() and send v2 with my: Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com> > --- > sound/soc/ti/j721e-evm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/ti/j721e-evm.c b/sound/soc/ti/j721e-evm.c > index b4b158dc736e..d9d1e021f5b2 100644 > --- a/sound/soc/ti/j721e-evm.c > +++ b/sound/soc/ti/j721e-evm.c > @@ -649,7 +649,7 @@ static int j721e_soc_probe_cpb(struct j721e_priv *priv, int *link_idx, > * Link 2: McASP10 <- pcm3168a_1 ADC > */ > comp_count = 6; > - compnent = devm_kzalloc(priv->dev, comp_count * sizeof(*compnent), > + compnent = devm_kcalloc(priv->dev, comp_count, sizeof(*compnent), > GFP_KERNEL); > if (!compnent) { > ret = -ENOMEM; > @@ -763,7 +763,7 @@ static int j721e_soc_probe_ivi(struct j721e_priv *priv, int *link_idx, > * \ pcm3168a_b ADC > */ > comp_count = 8; > - compnent = devm_kzalloc(priv->dev, comp_count * sizeof(*compnent), > + compnent = devm_kcalloc(priv->dev, comp_count, sizeof(*compnent), > GFP_KERNEL); > if (!compnent) { > ret = -ENOMEM; > -- > 2.25.1 >
diff --git a/sound/soc/ti/j721e-evm.c b/sound/soc/ti/j721e-evm.c index b4b158dc736e..d9d1e021f5b2 100644 --- a/sound/soc/ti/j721e-evm.c +++ b/sound/soc/ti/j721e-evm.c @@ -649,7 +649,7 @@ static int j721e_soc_probe_cpb(struct j721e_priv *priv, int *link_idx, * Link 2: McASP10 <- pcm3168a_1 ADC */ comp_count = 6; - compnent = devm_kzalloc(priv->dev, comp_count * sizeof(*compnent), + compnent = devm_kcalloc(priv->dev, comp_count, sizeof(*compnent), GFP_KERNEL); if (!compnent) { ret = -ENOMEM; @@ -763,7 +763,7 @@ static int j721e_soc_probe_ivi(struct j721e_priv *priv, int *link_idx, * \ pcm3168a_b ADC */ comp_count = 8; - compnent = devm_kzalloc(priv->dev, comp_count * sizeof(*compnent), + compnent = devm_kcalloc(priv->dev, comp_count, sizeof(*compnent), GFP_KERNEL); if (!compnent) { ret = -ENOMEM;
Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Link: https://github.com/KSPP/linux/issues/162 Signed-off-by: Erick Archer <erick.archer@gmx.com> --- sound/soc/ti/j721e-evm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1