| Message ID | 20240112163239.59743-1-kenzo.sgomez@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA | expand |
Hi, > -----Original Message----- > From: Kenzo Gomez <kenzo.sgomez@gmail.com> > Sent: Friday, January 12, 2024 4:32 PM > To: sbinding@opensource.cirrus.com > Cc: Kenzo Gomez <kenzo.sgomez@gmail.com>; James Schulman > <james.schulman@cirrus.com>; David Rhodes > <david.rhodes@cirrus.com>; Richard Fitzgerald > <rf@opensource.cirrus.com>; Jaroslav Kysela <perex@perex.cz>; Takashi > Iwai <tiwai@suse.com>; alsa-devel@alsa-project.org; > patches@opensource.cirrus.com; linux-sound@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH] ALSA: hda: cs35l41: Support additional ASUS Zenbook > UX3402VA > > Add new model entry into configuration table. > > Signed-off-by: Kenzo Gomez <kenzo.sgomez@gmail.com> > --- > sound/pci/hda/cs35l41_hda_property.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/hda/cs35l41_hda_property.c > b/sound/pci/hda/cs35l41_hda_property.c > index c1afb721b4c6..adfb31a6bf1e 100644 > --- a/sound/pci/hda/cs35l41_hda_property.c > +++ b/sound/pci/hda/cs35l41_hda_property.c > @@ -67,6 +67,7 @@ static const struct cs35l41_config > cs35l41_config_table[] = { > { "10431D1F", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, > { "10431DA2", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 1, 2, 0, 0, 0, 0 }, > { "10431E02", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 1, 2, 0, 0, 0, 0 }, > + { "104316A3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 1, 2, 0, 0, 0, 0 }, This entry looks correct, but this table is supposed to be sorted by SSID, can you move the entry to its correct location? > { "10431EE2", I2C, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 0, -1, -1, 0, 0, 0 }, > { "10431F12", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, > { "10431F1F", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 1, -1, 0, 0, 0, 0 }, > @@ -371,6 +372,7 @@ static const struct cs35l41_prop_model > cs35l41_prop_model_table[] = { > { "CSC3551", "10431D1F", generic_dsd_config }, > { "CSC3551", "10431DA2", generic_dsd_config }, > { "CSC3551", "10431E02", generic_dsd_config }, > + { "CSC3551", "104316A3", generic_dsd_config }, Same with this table, it should be sorted by SSID. > { "CSC3551", "10431EE2", generic_dsd_config }, > { "CSC3551", "10431F12", generic_dsd_config }, > { "CSC3551", "10431F1F", generic_dsd_config }, > -- > 2.43.0 > Thanks, Stefan
diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c index c1afb721b4c6..adfb31a6bf1e 100644 --- a/sound/pci/hda/cs35l41_hda_property.c +++ b/sound/pci/hda/cs35l41_hda_property.c @@ -67,6 +67,7 @@ static const struct cs35l41_config cs35l41_config_table[] = { { "10431D1F", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, { "10431DA2", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 }, { "10431E02", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 }, + { "104316A3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 }, { "10431EE2", I2C, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 }, { "10431F12", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, { "10431F1F", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 0, 0, 0 }, @@ -371,6 +372,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = { { "CSC3551", "10431D1F", generic_dsd_config }, { "CSC3551", "10431DA2", generic_dsd_config }, { "CSC3551", "10431E02", generic_dsd_config }, + { "CSC3551", "104316A3", generic_dsd_config }, { "CSC3551", "10431EE2", generic_dsd_config }, { "CSC3551", "10431F12", generic_dsd_config }, { "CSC3551", "10431F1F", generic_dsd_config },
Add new model entry into configuration table. Signed-off-by: Kenzo Gomez <kenzo.sgomez@gmail.com> --- sound/pci/hda/cs35l41_hda_property.c | 2 ++ 1 file changed, 2 insertions(+)