diff mbox series

Add a quirk for Yamaha YIT-W12TX transmitter

Message ID 20240123084935.2745-1-belegdol+github@gmail.com (mailing list archive)
State Accepted
Commit a969210066054ea109d8b7aff29a9b1c98776841
Headers show
Series Add a quirk for Yamaha YIT-W12TX transmitter | expand

Commit Message

Julian Sikorski Jan. 23, 2024, 8:49 a.m. UTC
The device fails to initialize otherwise, giving the following error:
[ 3676.671641] usb 2-1.1: 1:1: cannot get freq at ep 0x1

Signed-off-by: Julian Sikorski <belegdol+github@gmail.com>
---
 sound/usb/quirks.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Takashi Iwai Jan. 23, 2024, 9:10 a.m. UTC | #1
On Tue, 23 Jan 2024 09:49:35 +0100,
Julian Sikorski wrote:
> 
> The device fails to initialize otherwise, giving the following error:
> [ 3676.671641] usb 2-1.1: 1:1: cannot get freq at ep 0x1
> 
> Signed-off-by: Julian Sikorski <belegdol+github@gmail.com>

Thanks, I applied now.

But at the next time, try to check the following:

- Use a proper subject prefix; each subsystem has an own one, and this
  case would be "ALSA: usb-audio: Add a quirk..."

- Use the same mail address for both author and sign-off
  
- Put Cc-to-stable in the patch description instead of actually
  sending to it now


Takashi
Julian Sikorski Jan. 23, 2024, 9:19 a.m. UTC | #2
Am 23.01.24 um 10:10 schrieb Takashi Iwai:
> On Tue, 23 Jan 2024 09:49:35 +0100,
> Julian Sikorski wrote:
>>
>> The device fails to initialize otherwise, giving the following error:
>> [ 3676.671641] usb 2-1.1: 1:1: cannot get freq at ep 0x1
>>
>> Signed-off-by: Julian Sikorski <belegdol+github@gmail.com>
> 
> Thanks, I applied now.
> 
> But at the next time, try to check the following:
> 
> - Use a proper subject prefix; each subsystem has an own one, and this
>    case would be "ALSA: usb-audio: Add a quirk..."
> 
> - Use the same mail address for both author and sign-off
>    
> - Put Cc-to-stable in the patch description instead of actually
>    sending to it now
> 
> 
> Takashi
Thank you and apologies for the mistakes. I will try to do better next time.

Best regards,
Julian
diff mbox series

Patch

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index ab2b938502eb..bf0a7cca90d0 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -2031,6 +2031,8 @@  static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_CTL_MSG_DELAY_1M | QUIRK_FLAG_IGNORE_CTL_ERROR),
 	DEVICE_FLG(0x0499, 0x1509, /* Steinberg UR22 */
 		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
+	DEVICE_FLG(0x0499, 0x3108, /* Yamaha YIT-W12TX */
+		   QUIRK_FLAG_GET_SAMPLE_RATE),
 	DEVICE_FLG(0x04d8, 0xfeea, /* Benchmark DAC1 Pre */
 		   QUIRK_FLAG_GET_SAMPLE_RATE),
 	DEVICE_FLG(0x04e8, 0xa051, /* Samsung USBC Headset (AKG) */