| Message ID | 2024013031-tranquil-matador-a554@gregkh (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Soundwire: clean up sysfs group creation | expand |
Greg Kroah-Hartman wrote: > Now that we manually created our own attribute group list, the outdated > ATTRIBUTE_GROUPS() comments can be removed as they are not needed at > all. > > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Bard Liao <yung-chuan.liao@linux.intel.com> > Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Cc: Sanyog Kale <sanyog.r.kale@intel.com> > Cc: alsa-devel@alsa-project.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/soundwire/sysfs_slave.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/soundwire/sysfs_slave.c b/drivers/soundwire/sysfs_slave.c > index 0eefc205f697..f4259710dd0f 100644 > --- a/drivers/soundwire/sysfs_slave.c > +++ b/drivers/soundwire/sysfs_slave.c > @@ -129,10 +129,6 @@ static struct attribute *slave_dev_attrs[] = { > NULL, > }; > > -/* > - * we don't use ATTRIBUTES_GROUP here since we want to add a subdirectory > - * for device-level properties > - */ > static const struct attribute_group sdw_slave_dev_attr_group = { > .attrs = slave_dev_attrs, > .name = "dev-properties", > @@ -204,10 +200,6 @@ static bool dp0_group_visible(struct kobject *kobj) > } > DEFINE_SYSFS_GROUP_VISIBLE(dp0); > > -/* > - * we don't use ATTRIBUTES_GROUP here since we want to add a subdirectory > - * for dp0-level properties > - */ > static const struct attribute_group dp0_group = { > .attrs = dp0_attrs, > .is_visible = SYSFS_GROUP_VISIBLE(dp0), Not a great look when there are comments around avoiding common idioms. Reviewed-by: Dan Williams <dan.j.williams@intel.com>
diff --git a/drivers/soundwire/sysfs_slave.c b/drivers/soundwire/sysfs_slave.c index 0eefc205f697..f4259710dd0f 100644 --- a/drivers/soundwire/sysfs_slave.c +++ b/drivers/soundwire/sysfs_slave.c @@ -129,10 +129,6 @@ static struct attribute *slave_dev_attrs[] = { NULL, }; -/* - * we don't use ATTRIBUTES_GROUP here since we want to add a subdirectory - * for device-level properties - */ static const struct attribute_group sdw_slave_dev_attr_group = { .attrs = slave_dev_attrs, .name = "dev-properties", @@ -204,10 +200,6 @@ static bool dp0_group_visible(struct kobject *kobj) } DEFINE_SYSFS_GROUP_VISIBLE(dp0); -/* - * we don't use ATTRIBUTES_GROUP here since we want to add a subdirectory - * for dp0-level properties - */ static const struct attribute_group dp0_group = { .attrs = dp0_attrs, .is_visible = SYSFS_GROUP_VISIBLE(dp0),
Now that we manually created our own attribute group list, the outdated ATTRIBUTE_GROUPS() comments can be removed as they are not needed at all. Cc: Vinod Koul <vkoul@kernel.org> Cc: Bard Liao <yung-chuan.liao@linux.intel.com> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Cc: Sanyog Kale <sanyog.r.kale@intel.com> Cc: alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/soundwire/sysfs_slave.c | 8 -------- 1 file changed, 8 deletions(-)