diff mbox series

ALSA: hda/tas2781: remove unnecessary runtime_pm calls

Message ID 20240312161217.79510-1-pierre-louis.bossart@linux.intel.com (mailing list archive)
State Accepted
Commit 526d028341f73c0f2dbd5e4855a59ebb6d620be5
Headers show
Series ALSA: hda/tas2781: remove unnecessary runtime_pm calls | expand

Commit Message

Pierre-Louis Bossart March 12, 2024, 4:12 p.m. UTC
The runtime_pm handling seems to have been loosely inspired by the
cs32l41 driver, but in this case the get_noresume/put sequence is not
required.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/pci/hda/tas2781_hda_i2c.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Takashi Iwai March 12, 2024, 6:59 p.m. UTC | #1
On Tue, 12 Mar 2024 17:12:17 +0100,
Pierre-Louis Bossart wrote:
> 
> The runtime_pm handling seems to have been loosely inspired by the
> cs32l41 driver, but in this case the get_noresume/put sequence is not
> required.
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Thanks, applied.


Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index 2eb1f9e443c0..4475cea8e9f7 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -796,11 +796,8 @@  static int tas2781_hda_i2c_probe(struct i2c_client *clt)
 	pm_runtime_use_autosuspend(tas_hda->dev);
 	pm_runtime_mark_last_busy(tas_hda->dev);
 	pm_runtime_set_active(tas_hda->dev);
-	pm_runtime_get_noresume(tas_hda->dev);
 	pm_runtime_enable(tas_hda->dev);
 
-	pm_runtime_put_autosuspend(tas_hda->dev);
-
 	tas2781_reset(tas_hda->priv);
 
 	ret = component_add(tas_hda->dev, &tas2781_hda_comp_ops);