| Message ID | 20240325070944.3600338-5-dlemoal@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Remove PCI_IRQ_LEGACY | expand |
On 3/25/2024 8:09 AM, Damien Le Moal wrote: > Use the macro PCI_IRQ_INTX instead of the deprecated PCI_IRQ_LEGACY > macro. > > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> > --- > sound/soc/intel/avs/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/avs/core.c b/sound/soc/intel/avs/core.c > index d7f8940099ce..69818e4b43da 100644 > --- a/sound/soc/intel/avs/core.c > +++ b/sound/soc/intel/avs/core.c > @@ -343,7 +343,7 @@ static int avs_hdac_acquire_irq(struct avs_dev *adev) > int ret; > > /* request one and check that we only got one interrupt */ > - ret = pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI | PCI_IRQ_LEGACY); > + ret = pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI | PCI_IRQ_INTX); > if (ret != 1) { > dev_err(adev->dev, "Failed to allocate IRQ vector: %d\n", ret); > return ret; Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
On 3/25/2024 1:34 PM, Amadeusz Sławiński wrote: > On 3/25/2024 8:09 AM, Damien Le Moal wrote: >> Use the macro PCI_IRQ_INTX instead of the deprecated PCI_IRQ_LEGACY >> macro. >> >> Signed-off-by: Damien Le Moal <dlemoal@kernel.org> >> --- >> sound/soc/intel/avs/core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/intel/avs/core.c b/sound/soc/intel/avs/core.c >> index d7f8940099ce..69818e4b43da 100644 >> --- a/sound/soc/intel/avs/core.c >> +++ b/sound/soc/intel/avs/core.c >> @@ -343,7 +343,7 @@ static int avs_hdac_acquire_irq(struct avs_dev *adev) >> int ret; >> /* request one and check that we only got one interrupt */ >> - ret = pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI | >> PCI_IRQ_LEGACY); >> + ret = pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI | PCI_IRQ_INTX); >> if (ret != 1) { >> dev_err(adev->dev, "Failed to allocate IRQ vector: %d\n", ret); >> return ret; > > Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Sorry, one more thing, can you adjust commit title to: ASoC: Intel: avs: Use PCI_IRQ_INTX and with that, you can add above Reviewed-by: Thanks!
diff --git a/sound/soc/intel/avs/core.c b/sound/soc/intel/avs/core.c index d7f8940099ce..69818e4b43da 100644 --- a/sound/soc/intel/avs/core.c +++ b/sound/soc/intel/avs/core.c @@ -343,7 +343,7 @@ static int avs_hdac_acquire_irq(struct avs_dev *adev) int ret; /* request one and check that we only got one interrupt */ - ret = pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI | PCI_IRQ_LEGACY); + ret = pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI | PCI_IRQ_INTX); if (ret != 1) { dev_err(adev->dev, "Failed to allocate IRQ vector: %d\n", ret); return ret;
Use the macro PCI_IRQ_INTX instead of the deprecated PCI_IRQ_LEGACY macro. Signed-off-by: Damien Le Moal <dlemoal@kernel.org> --- sound/soc/intel/avs/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)