diff mbox series

Add support for 2024 ROG Strix G634JZR

Message ID 20240401-add-rog-strix-16-g634jzr-v1-1-ac396095409e@dberlin.org (mailing list archive)
State New
Headers show
Series Add support for 2024 ROG Strix G634JZR | expand

Commit Message

Daniel Berlin via B4 Relay April 1, 2024, 2:31 p.m. UTC 
From: Daniel Berlin <dberlin@dberlin.org>

The windows driver inf says it uses the exact same tunings and setup as the
older G634, and then reuses the data for ID 1043:1CAF.

We do the same here.
Tested on an actual laptop, sound works fine with this patch plus
default fallback firmware.

Signed-off-by: Daniel Berlin <dberlin@dberlin.org>
---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)


---
base-commit: 39cd87c4eb2b893354f3b850f916353f2658ae6f
change-id: 20240401-add-rog-strix-16-g634jzr-9e5490cadc2b

Best regards,

Comments

Takashi Iwai April 2, 2024, 6:13 a.m. UTC | #1 
On Tue, 02 Apr 2024 08:04:39 +0200,
Takashi Iwai wrote:
> 
> On Mon, 01 Apr 2024 16:31:30 +0200,
> Daniel Berlin via B4 Relay wrote:
> > 
> > From: Daniel Berlin <dberlin@dberlin.org>
> > 
> > The windows driver inf says it uses the exact same tunings and setup as the
> > older G634, and then reuses the data for ID 1043:1CAF.
> > 
> > We do the same here.
> > Tested on an actual laptop, sound works fine with this patch plus
> > default fallback firmware.
> > 
> > Signed-off-by: Daniel Berlin <dberlin@dberlin.org>
> 
> Applied now.  Thanks.

... and now I see that Luke has another patch that modified the entry
in patch_realtek.c, and I took his version instead.
  https://lore.kernel.org/r/20240402015126.21115-1-luke@ljones.dev

Let me know if this causes problem for you.


thanks,

Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index 72ec872afb8d..25c117db3317 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -108,6 +108,7 @@  static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "10431F12", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431F1F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 0, 0, 0 },
 	{ "10431F62", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
+	{ "10433A60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "17AA386F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
 	{ "17AA38A9", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
 	{ "17AA38AB", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
@@ -496,6 +497,7 @@  static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "10431F12", generic_dsd_config },
 	{ "CSC3551", "10431F1F", generic_dsd_config },
 	{ "CSC3551", "10431F62", generic_dsd_config },
+	{ "CSC3551", "10433A60", generic_dsd_config },
 	{ "CSC3551", "17AA386F", generic_dsd_config },
 	{ "CSC3551", "17AA38A9", generic_dsd_config },
 	{ "CSC3551", "17AA38AB", generic_dsd_config },