| Message ID | 20240404160649.967-1-bavishimithil@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dt-bindings: omap-mcpdm: Convert to DT schema | expand |
So sorry about the 2nd patch being sent as a new mail, here is a new patch with the changes as suggested > Please use subject prefixes matching the subsystem Changed the patch name to match the folder history. > Is it your full name? Fixed it, my apologies. > Filename like compatible. Fixed. > Please open existing bindings and look how it is done there. Changed it, is it fine now? > Same problem. Drop useless description but provide maxItems. Removed descriptions for interrupts and hwmods. > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` I did run it and it didnt produce any errors henceforth i submitted the patch. > Node names should be generic Changed as said. >From c24a42724e870822d50ac6857ba9f32d0dce02ae Mon Sep 17 00:00:00 2001 From: Mithil Bavishi <bavishimithil@gmail.com> Date: Mon, 1 Apr 2024 21:10:15 +0530 Subject: [PATCH v2] dt-bindings: omap-mcpdm: Convert to DT schema Convert the OMAP4+ McPDM bindings to DT schema. Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com> --- .../devicetree/bindings/sound/omap-mcpdm.txt | 30 ---------- .../bindings/sound/ti,omap-mcpdm.yaml | 59 +++++++++++++++++++ 2 files changed, 59 insertions(+), 30 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/omap-mcpdm.txt create mode 100644 Documentation/devicetree/bindings/sound/ti,omap-mcpdm.yaml diff --git a/Documentation/devicetree/bindings/sound/omap-mcpdm.txt b/Documentation/devicetree/bindings/sound/omap-mcpdm.txt deleted file mode 100644 index ff98a0cb5..000000000 --- a/Documentation/devicetree/bindings/sound/omap-mcpdm.txt +++ /dev/null @@ -1,30 +0,0 @@ -* Texas Instruments OMAP4+ McPDM - -Required properties: -- compatible: "ti,omap4-mcpdm" -- reg: Register location and size as an array: - <MPU access base address, size>, - <L3 interconnect address, size>; -- interrupts: Interrupt number for McPDM -- ti,hwmods: Name of the hwmod associated to the McPDM -- clocks: phandle for the pdmclk provider, likely <&twl6040> -- clock-names: Must be "pdmclk" - -Example: - -mcpdm: mcpdm@40132000 { - compatible = "ti,omap4-mcpdm"; - reg = <0x40132000 0x7f>, /* MPU private access */ - <0x49032000 0x7f>; /* L3 Interconnect */ - interrupts = <0 112 0x4>; - interrupt-parent = <&gic>; - ti,hwmods = "mcpdm"; -}; - -In board DTS file the pdmclk needs to be added: - -&mcpdm { - clocks = <&twl6040>; - clock-names = "pdmclk"; - status = "okay"; -}; diff --git a/Documentation/devicetree/bindings/sound/ti,omap-mcpdm.yaml b/Documentation/devicetree/bindings/sound/ti,omap-mcpdm.yaml new file mode 100644 index 000000000..4d5d37e98 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ti,omap-mcpdm.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ti,omap-mcpdm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OMAP McPDM + +maintainers: + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> + +description: + OMAP ALSA SoC DAI driver using McPDM port used by TWL6040 + +properties: + compatible: + const: ti,omap4-mcpdm + + reg: + description: + Register location and size as an array + <MPU access base address, size>, + <L3 interconnect address, size>; + + interrupts: + maxItems: 1 + + ti,hwmods: + maxItems: 1 + + clocks: + description: phandle for the pdmclk provider, likely <&twl6040> + + clock-names: + description: Must be "pdmclk" + + +required: + - compatible + - reg + - interrupts + - ti,hwmods + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + mcpdm@0 { + compatible = "ti,omap4-mcpdm"; + reg = <0x40132000 0x7f>, /* MPU private access */ + <0x49032000 0x7f>; /* L3 Interconnect */ + interrupts = <0 112 0x4>; + interrupt-parent = <&gic>; + ti,hwmods = "mcpdm"; + clocks = <&twl6040>; + clock-names = "pdmclk"; + }; -- 2.34.1 Best regards, Mithil On Fri, Apr 5, 2024 at 12:28 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 04/04/2024 18:06, Mighty wrote: > > From: Mithil Bavishi <bavishimithil@gmail.com> > > > > Convert the OMAP4+ McPDM bindings to DT schema. > > > > Signed-off-by: Mighty <bavishimithil@gmail.com> > > This does not match SoB. Can you respond to comments you receive? > > Subject: nothing improved. > > Rest... also did not improve. so you ignored entire feedback? > > This is a friendly reminder during the review process. > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion and > either implement all requested changes or keep discussing them. > > Thank you. > > Best regards, > Krzysztof >
On Fri, Apr 5, 2024 at 9:27 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 05/04/2024 16:48, Mithil wrote: > > So sorry about the 2nd patch being sent as a new mail, here is a new > > patch with the changes as suggested > > > >> Please use subject prefixes matching the subsystem > > Changed the patch name to match the folder history. > > Nothing improved. What the history tells you? > Referred to "ASoC: dt-bindings: rt1015: Convert to dtschema" Not really sure what else I should change. > > > >> Is it your full name? > > Fixed it, my apologies. > > > >> Filename like compatible. > > Fixed. > > Still not, compatible is omap4. > Sorry, seems like I was sending the old file again. Will fix this. > > > >> Please open existing bindings and look how it is done there. > > Changed it, is it fine now? > > You mean v2? I have no clue to what you are responding here, but no, v2 > did not improve much. > Again, could you guide me to what needs to be done? Description for reg should be fine as this is how it is done in other files as well. Interrupts and hwmods use maxItems now. Changed nodename to be generic in example as well. Those were the suggested changes previously. Best regards, Mithil
On Fri, Apr 5, 2024 at 10:38 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 05/04/2024 18:29, Mithil wrote: > > On Fri, Apr 5, 2024 at 9:27 PM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 05/04/2024 16:48, Mithil wrote: > >>> So sorry about the 2nd patch being sent as a new mail, here is a new > >>> patch with the changes as suggested > >>> > >>>> Please use subject prefixes matching the subsystem > >>> Changed the patch name to match the folder history. > >> > >> Nothing improved. What the history tells you? > >> > > > > Referred to "ASoC: dt-bindings: rt1015: Convert to dtschema" > > Not really sure what else I should change. > > But the subject you wrote here is "dt-bindings: omap-mcpdm: Convert to > DT schema"? > > Where is the ASoC? > I did change it, will send the patch again. > > reg is not correct. Please point me to files doing that way, so I can > fix them. > > You need items with description. > Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml I referred here for the description, but will add items for the 2 regs > > Interrupts and hwmods use maxItems now. > > hwmods lost description, why? Seems self explanatory. > > Changed nodename to be generic in example as well. > > "mcpdm" does not feel generic. What is mcpdm? Google finds nothing. > Maybe just "pdm"? > Multichannel PDM Controller. Kept it like that since the node is also called as mcpdm in the devicetree. Calling it pdm might cause confusion. Best Regards, Mithil
On Fri, Apr 5, 2024 at 11:49 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 05/04/2024 19:21, Mithil wrote: > > On Fri, Apr 5, 2024 at 10:38 PM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 05/04/2024 18:29, Mithil wrote: > >>> On Fri, Apr 5, 2024 at 9:27 PM Krzysztof Kozlowski > >>> <krzysztof.kozlowski@linaro.org> wrote: > >>>> > >>>> On 05/04/2024 16:48, Mithil wrote: > >>>>> So sorry about the 2nd patch being sent as a new mail, here is a new > >>>>> patch with the changes as suggested > >>>>> > >>>>>> Please use subject prefixes matching the subsystem > >>>>> Changed the patch name to match the folder history. > >>>> > >>>> Nothing improved. What the history tells you? > >>>> > >>> > >>> Referred to "ASoC: dt-bindings: rt1015: Convert to dtschema" > >>> Not really sure what else I should change. > >> > >> But the subject you wrote here is "dt-bindings: omap-mcpdm: Convert to > >> DT schema"? > >> > >> Where is the ASoC? > >> > > I did change it, will send the patch again. > > > >> > >> reg is not correct. Please point me to files doing that way, so I can > >> fix them. > >> > >> You need items with description. > >> > > Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml > > I referred here for the description, but will add items for the 2 regs > > I don't see at all the code you are using. It's entirely different! > Where in this file is that type of "reg" property? > Changed it to use items and description. Was not aware about this format apologies. > > > >>> Interrupts and hwmods use maxItems now. > >> > >> hwmods lost description, why? > > Seems self explanatory. > > Really? Not to me. I have no clue what this is. Also, you need > description for (almost) every non-standard, vendor property. > Re-added it as it was previously. > > > >>> Changed nodename to be generic in example as well. > >> > >> "mcpdm" does not feel generic. What is mcpdm? Google finds nothing. > >> Maybe just "pdm"? > >> > > Multichannel PDM Controller. Kept it like that since the node is also > > You said you "changed nodename". So from what did you change to what? > > > called as mcpdm in the devicetree. Calling it pdm might cause > > Poor DTS is not the example... > > > confusion. > > So far I am confused. Often name of SoC block is specific, not generic. > Anyway, that's not important part, so if you claim mcpdm is generic name > of a class of devices, I am fine. > Changed to pdm. Here's the patch, >From 9fb94e551da1ff06d489f60d52335001a9de9976 Mon Sep 17 00:00:00 2001 From: Mithil Bavishi <bavishimithil@gmail.com> Date: Mon, 1 Apr 2024 21:10:15 +0530 Subject: [PATCH] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema Convert the OMAP4+ McPDM bindings to DT schema. Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com> --- .../devicetree/bindings/sound/omap-mcpdm.txt | 30 ---------- .../bindings/sound/ti,omap4-mcpdm.yaml | 58 +++++++++++++++++++ 2 files changed, 58 insertions(+), 30 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/omap-mcpdm.txt create mode 100644 Documentation/devicetree/bindings/sound/ti,omap4-mcpdm.yaml diff --git a/Documentation/devicetree/bindings/sound/omap-mcpdm.txt b/Documentation/devicetree/bindings/sound/omap-mcpdm.txt deleted file mode 100644 index ff98a0cb5..000000000 --- a/Documentation/devicetree/bindings/sound/omap-mcpdm.txt +++ /dev/null @@ -1,30 +0,0 @@ -* Texas Instruments OMAP4+ McPDM - -Required properties: -- compatible: "ti,omap4-mcpdm" -- reg: Register location and size as an array: - <MPU access base address, size>, - <L3 interconnect address, size>; -- interrupts: Interrupt number for McPDM -- ti,hwmods: Name of the hwmod associated to the McPDM -- clocks: phandle for the pdmclk provider, likely <&twl6040> -- clock-names: Must be "pdmclk" - -Example: - -mcpdm: mcpdm@40132000 { - compatible = "ti,omap4-mcpdm"; - reg = <0x40132000 0x7f>, /* MPU private access */ - <0x49032000 0x7f>; /* L3 Interconnect */ - interrupts = <0 112 0x4>; - interrupt-parent = <&gic>; - ti,hwmods = "mcpdm"; -}; - -In board DTS file the pdmclk needs to be added: - -&mcpdm { - clocks = <&twl6040>; - clock-names = "pdmclk"; - status = "okay"; -}; diff --git a/Documentation/devicetree/bindings/sound/ti,omap4-mcpdm.yaml b/Documentation/devicetree/bindings/sound/ti,omap4-mcpdm.yaml new file mode 100644 index 000000000..73fcfaf6e --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ti,omap4-mcpdm.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ti,omap4-mcpdm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OMAP McPDM + +maintainers: + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> + +description: + OMAP ALSA SoC DAI driver using McPDM port used by TWL6040 + +properties: + compatible: + const: ti,omap4-mcpdm + + reg: + items: + - description: MPU access base address + - description: L3 interconnect address + + interrupts: + maxItems: 1 + + ti,hwmods: + description: Name of the hwmod associated to the McPDM, likely "mcpdm" + + clocks: + description: phandle for the pdmclk provider, likely <&twl6040> + + clock-names: + description: Must be "pdmclk" + + +required: + - compatible + - reg + - interrupts + - ti,hwmods + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + pdm@0 { + compatible = "ti,omap4-mcpdm"; + reg = <0x40132000 0x7f>, /* MPU private access */ + <0x49032000 0x7f>; /* L3 Interconnect */ + interrupts = <0 112 0x4>; + interrupt-parent = <&gic>; + ti,hwmods = "mcpdm"; + clocks = <&twl6040>; + clock-names = "pdmclk"; + }; -- 2.34.1 Best regards, Mithil
Hello, Is the patch better now? I'd still like to learn from where i did the mistakes (which seem very silly now) Best Regards, Mithil
On 12/04/2024 16:16, Mithil wrote: > Hello, > Is the patch better now? I'd still like to learn from where i did the > mistakes (which seem very silly now) I do not recall any new patch from you. Please follow submitting patches document. Each patch is a new submission (new, not reply to something), with versioning, with changelog under ---. For example generated with `git format-patch -v3 -1`. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/omap-mcpdm.txt b/Documentation/devicetree/bindings/sound/omap-mcpdm.txt deleted file mode 100644 index ff98a0cb5..000000000 --- a/Documentation/devicetree/bindings/sound/omap-mcpdm.txt +++ /dev/null @@ -1,30 +0,0 @@ -* Texas Instruments OMAP4+ McPDM - -Required properties: -- compatible: "ti,omap4-mcpdm" -- reg: Register location and size as an array: - <MPU access base address, size>, - <L3 interconnect address, size>; -- interrupts: Interrupt number for McPDM -- ti,hwmods: Name of the hwmod associated to the McPDM -- clocks: phandle for the pdmclk provider, likely <&twl6040> -- clock-names: Must be "pdmclk" - -Example: - -mcpdm: mcpdm@40132000 { - compatible = "ti,omap4-mcpdm"; - reg = <0x40132000 0x7f>, /* MPU private access */ - <0x49032000 0x7f>; /* L3 Interconnect */ - interrupts = <0 112 0x4>; - interrupt-parent = <&gic>; - ti,hwmods = "mcpdm"; -}; - -In board DTS file the pdmclk needs to be added: - -&mcpdm { - clocks = <&twl6040>; - clock-names = "pdmclk"; - status = "okay"; -}; diff --git a/Documentation/devicetree/bindings/sound/ti,omap-mcpdm.yaml b/Documentation/devicetree/bindings/sound/ti,omap-mcpdm.yaml new file mode 100644 index 000000000..4d5d37e98 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ti,omap-mcpdm.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ti,omap-mcpdm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OMAP McPDM + +maintainers: + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> + +description: + OMAP ALSA SoC DAI driver using McPDM port used by TWL6040 + +properties: + compatible: + const: ti,omap4-mcpdm + + reg: + description: + Register location and size as an array + <MPU access base address, size>, + <L3 interconnect address, size>; + + interrupts: + maxItems: 1 + + ti,hwmods: + maxItems: 1 + + clocks: + description: phandle for the pdmclk provider, likely <&twl6040> + + clock-names: + description: Must be "pdmclk" + + +required: + - compatible + - reg + - interrupts + - ti,hwmods + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + mcpdm@0 { + compatible = "ti,omap4-mcpdm"; + reg = <0x40132000 0x7f>, /* MPU private access */ + <0x49032000 0x7f>; /* L3 Interconnect */ + interrupts = <0 112 0x4>; + interrupt-parent = <&gic>; + ti,hwmods = "mcpdm"; + clocks = <&twl6040>; + clock-names = "pdmclk"; + };