| Message ID | 20240408042331.403103-3-quic_mohs@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5485c3fa96f78314207a30e81dbe270424d70ede |
| Headers | show |
| Series | Add support for QCM6490 and QCS6490 | expand |
On Mon, Apr 08, 2024 at 09:53:31AM +0530, Mohammad Rafi Shaik wrote: > Add compatibles for sound card on Qualcomm QCM6490 IDP and > QCS6490 RB3Gen2 boards. > > Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> > --- > sound/soc/qcom/sc8280xp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c > index b7fd503a1666..878bd50ad4a7 100644 > --- a/sound/soc/qcom/sc8280xp.c > +++ b/sound/soc/qcom/sc8280xp.c > @@ -169,6 +169,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev) > } > > static const struct of_device_id snd_sc8280xp_dt_match[] = { > + {.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"}, > + {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"}, We now have 4 <platform>-sndcard and two <board>-sndcard compatibles here. Not saying that your patch is wrong, but is this driver board-specific or soc-specific? Srinivas, Krzysztof? Regards, Bjorn > {.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"}, > {.compatible = "qcom,sm8450-sndcard", "sm8450"}, > {.compatible = "qcom,sm8550-sndcard", "sm8550"}, > -- > 2.25.1 > >
On 08/04/2024 14:45, Bjorn Andersson wrote: > On Mon, Apr 08, 2024 at 09:53:31AM +0530, Mohammad Rafi Shaik wrote: >> Add compatibles for sound card on Qualcomm QCM6490 IDP and >> QCS6490 RB3Gen2 boards. >> >> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> >> --- >> sound/soc/qcom/sc8280xp.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c >> index b7fd503a1666..878bd50ad4a7 100644 >> --- a/sound/soc/qcom/sc8280xp.c >> +++ b/sound/soc/qcom/sc8280xp.c >> @@ -169,6 +169,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev) >> } >> >> static const struct of_device_id snd_sc8280xp_dt_match[] = { >> + {.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"}, >> + {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"}, > > We now have 4 <platform>-sndcard and two <board>-sndcard compatibles > here. > > Not saying that your patch is wrong, but is this driver board-specific > or soc-specific? Srinivas, Krzysztof? To my understanding this is mostly board specific, but it is also partially a software construct thus we simplify it by using SoC compatible for all boards with given SoC. I have no clue whether this applies here. I think we asked about clarifying the differences, but as you can see nothing improved in the commit msg. Best regards, Krzysztof
On 08/04/2024 13:45, Bjorn Andersson wrote: > On Mon, Apr 08, 2024 at 09:53:31AM +0530, Mohammad Rafi Shaik wrote: >> Add compatibles for sound card on Qualcomm QCM6490 IDP and >> QCS6490 RB3Gen2 boards. >> >> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> >> --- >> sound/soc/qcom/sc8280xp.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c >> index b7fd503a1666..878bd50ad4a7 100644 >> --- a/sound/soc/qcom/sc8280xp.c >> +++ b/sound/soc/qcom/sc8280xp.c >> @@ -169,6 +169,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev) >> } >> >> static const struct of_device_id snd_sc8280xp_dt_match[] = { >> + {.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"}, >> + {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"}, > > We now have 4 <platform>-sndcard and two <board>-sndcard compatibles > here. > > Not saying that your patch is wrong, but is this driver board-specific > or soc-specific? Srinivas, Krzysztof? Normally this should be board specific. In the past we made them SoC specific and provided a way to do board specific changes based on compatible. Recently we stopped adding new drivers as most of these drivers turned out to be identical and lots of code duplication. Having these compatibles will help both the userspace UCM and provide hooks to do any board/soc specific configurations. thanks, Srini > > Regards, > Bjorn > >> {.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"}, >> {.compatible = "qcom,sm8450-sndcard", "sm8450"}, >> {.compatible = "qcom,sm8550-sndcard", "sm8550"}, >> -- >> 2.25.1 >> >>
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c index b7fd503a1666..878bd50ad4a7 100644 --- a/sound/soc/qcom/sc8280xp.c +++ b/sound/soc/qcom/sc8280xp.c @@ -169,6 +169,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev) } static const struct of_device_id snd_sc8280xp_dt_match[] = { + {.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"}, + {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"}, {.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"}, {.compatible = "qcom,sm8450-sndcard", "sm8450"}, {.compatible = "qcom,sm8550-sndcard", "sm8550"},
Add compatibles for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards. Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> --- sound/soc/qcom/sc8280xp.c | 2 ++ 1 file changed, 2 insertions(+)