diff mbox series

[2/4] ALSA: pci: emu10k: delete usage of 'struct snd_pcm_runtime.sync'

Message ID 20240501113445.100817-3-o-takashi@sakamocchi.jp (mailing list archive)
State New
Headers show
Series ALSA: pcm: obsolete sync member in runtime structure | expand

Commit Message

Takashi Sakamoto May 1, 2024, 11:34 a.m. UTC 
In Linux kernel version 4.13, the data of snd_pcm_sync_id union is not
exposed to user space by a commit e11f0f90a626 ("ALSA: pcm: remove
SNDRV_PCM_IOCTL1_INFO internal command"). From then, we have received
no issues from users or developers for emu10k.

This commit deletes the usage of 'struct snd_pcm_runtime.sync' from the
driver.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/pci/emu10k1/p16v.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
diff mbox series

Patch

diff --git a/sound/pci/emu10k1/p16v.c b/sound/pci/emu10k1/p16v.c
index e7f097cae574..86ab86d1ec2b 100644
--- a/sound/pci/emu10k1/p16v.c
+++ b/sound/pci/emu10k1/p16v.c
@@ -170,16 +170,7 @@  static int snd_p16v_pcm_open_playback_channel(struct snd_pcm_substream *substrea
 	       channel_id, chip, channel);
 #endif /* debug */
 	/* channel->interrupt = snd_p16v_pcm_channel_interrupt; */
-	err = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS);
-	if (err < 0)
-                return err;
-
-	runtime->sync.id32[0] = substream->pcm->card->number;
-	runtime->sync.id32[1] = 'P';
-	runtime->sync.id32[2] = 16;
-	runtime->sync.id32[3] = 'V';
-
-	return 0;
+	return snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS);
 }
 
 /* open_capture callback */