| Message ID | 20240622124603.2606770-3-christianshewitt@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: add compatible for ti,pcm5242 | expand |
On Sat, Jun 22, 2024 at 12:46:03PM +0000, Christian Hewitt wrote: > Add a compatible string to enable support for the ti,pcm5242 DAC chip > in the pcm512x driver. > > Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> > --- > sound/soc/codecs/pcm512x-i2c.c | 2 ++ > 1 file changed, 2 insertions(+) The device appears to have SPI support too like the other devices in the family, why not add the ID for SPI as well: https://www.ti.com/product/PCM5242
> On 22 Jun 2024, at 5:03 PM, Mark Brown <broonie@kernel.org> wrote: > > On Sat, Jun 22, 2024 at 12:46:03PM +0000, Christian Hewitt wrote: >> Add a compatible string to enable support for the ti,pcm5242 DAC chip >> in the pcm512x driver. >> >> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> >> --- >> sound/soc/codecs/pcm512x-i2c.c | 2 ++ >> 1 file changed, 2 insertions(+) > > The device appears to have SPI support too like the other devices in the > family, why not add the ID for SPI as well: > > https://www.ti.com/product/PCM5242 Okay, will do. I need to send v2 anyway as I fat-fingered the chip number in the bindings patch subject/description :( Christian
diff --git a/sound/soc/codecs/pcm512x-i2c.c b/sound/soc/codecs/pcm512x-i2c.c index 4be476a280e1..92bcf5179779 100644 --- a/sound/soc/codecs/pcm512x-i2c.c +++ b/sound/soc/codecs/pcm512x-i2c.c @@ -39,6 +39,7 @@ static const struct i2c_device_id pcm512x_i2c_id[] = { { "pcm5122", }, { "pcm5141", }, { "pcm5142", }, + { "pcm5242", }, { "tas5754", }, { "tas5756", }, { } @@ -51,6 +52,7 @@ static const struct of_device_id pcm512x_of_match[] = { { .compatible = "ti,pcm5122", }, { .compatible = "ti,pcm5141", }, { .compatible = "ti,pcm5142", }, + { .compatible = "ti,pcm5242", }, { .compatible = "ti,tas5754", }, { .compatible = "ti,tas5756", }, { }
Add a compatible string to enable support for the ti,pcm5242 DAC chip in the pcm512x driver. Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> --- sound/soc/codecs/pcm512x-i2c.c | 2 ++ 1 file changed, 2 insertions(+)