diff mbox series

ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA

Message ID 20240626055131.44014-1-itmymaill@gmail.com (mailing list archive)
State Superseded
Headers show
Series ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA | expand

Commit Message

Vyacheslav Frantsishko June 26, 2024, 5:51 a.m. UTC
Signed-off-by: Vyacheslav Frantsishko <itmymaill@gmail.com>

The Vivobook S 16X IPS needs a quirks-table entry for the internal microphone to function properly.
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Mario Limonciello June 26, 2024, 5:55 a.m. UTC | #1
On 6/26/2024 00:51, Vyacheslav Frantsishko wrote:
> Signed-off-by: Vyacheslav Frantsishko <itmymaill@gmail.com>
> 
> The Vivobook S 16X IPS needs a quirks-table entry for the internal microphone to function properly.
> ---
This is a Ryzen 6000 (YC) product, so this does look like the right 
solution.

Your SoB tag is in the wrong place (should be at end of commit message), 
not sure if ALSA guys can fix that while committing or you need to 
re-submit.

But the content looks fine to me otherwise.

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

>   sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 1760b5d42460..4e3a8ce690a4 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"),
>   		}
>   	},
> +        {
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "M5602RA"),
> +		}
> +	},
>   	{
>   		.driver_data = &acp6x_card,
>   		.matches = {
diff mbox series

Patch

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 1760b5d42460..4e3a8ce690a4 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -283,6 +283,13 @@  static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"),
 		}
 	},
+        {
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "M5602RA"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {