From patchwork Mon Jul 1 07:02:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13717600 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BE087C086 for ; Mon, 1 Jul 2024 07:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719817364; cv=none; b=CCC6aeJ+QwbGQiOeE7G+omdPZ1qQWJZLudwCq4Cp+767W9YQX/ZKZgTvtYyaI3WHDcoDBcS7VYpSne5mosrF83kBeo5tSHJ3qHwJZ9R0JKrsCzYYuSYo21rsNiNabPLApZl7eVOs6cMZH79pJk/+2ePooi62ueBV6hb16TMBqKc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719817364; c=relaxed/simple; bh=pcOvFSy9mqnG9tdnejsIswIHJuVcxQ0Q95HAQWqfY2Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Xj46ijqMubwp6sI37qoklxnjjul//djv3dFqM/cIiB+zkDaNfsjX6WmZaTJgJtIpdl2AizTjAW8JRJE//xYfWZ5uOewDMcUofy7HdXHu58k2LvogSuVxkdg4scwYLoPWBpFVtNHnZ08QwRFVcBQsOMsBc3VWm/byS1uBmz5YKco= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oSA4RBaT; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oSA4RBaT" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2ebed33cb65so27940081fa.2 for ; Mon, 01 Jul 2024 00:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719817361; x=1720422161; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pWt7xul9gaEWvRdXPJZ452zrHt44xP6eq1TOlG30kGE=; b=oSA4RBaTJCLVkTNLkMcohSiSe9qnXixHSiIAQlAgPpi0C/yxy2sLFIvKiukccxoEy3 PFFCDnUo5MbW+mdqoPPBSUlu6+8AQFI9DhQzCZLfbGcGoUa7O2X24RBFZrzDWb18J2tV yPmYmAnjYDplRK1NEXrDAOPqBrcF8CxkvQBHXeaXFtO3pyVAZV+qHU8hybUf00UDPCjf ZqJndefvhluHRLd2FLnCrTiXFqdMi1Sn297sv7QOcYzyDWKF1OY5VPdYNunVBnpJsPv4 STg+BFnKD5VYUVd9bxj3VpSsZwjCGJ1ZSR3CSekIwJOUZIIoSlcm4GhF1UaVyliFGoJW D5Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719817361; x=1720422161; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pWt7xul9gaEWvRdXPJZ452zrHt44xP6eq1TOlG30kGE=; b=RKTXoANhln1L96jlwYu5mmc5VoYE5QM9Q0KxweU6tu91fgmGVQjJ0q3ny1OxdcpoAU ZzPB8qrpzFlJJ6wsziWHPjni4kApaNUCsWoMV0aDjccPjyrTOEvVHnTY8prVfUopKCrn EJwCzduj6y/cbyN8FdVsYJSGXGzSIYduxThiDqeDXgFnuPM8erIcLEP4WMUvwlmSOsXA EhSk+5XTbcwoxFplv+MgFnzug3GW9WGkZ/8SDIsHIwPFgKD/NS23AiMrDHQSFBpjvwj3 eHx6RXjVU22Ptm8H83cluOe9J+eoDhbLQTk4HAHdK5oARuuEsvwQIHFMbxqGYzUgiHl4 QD5w== X-Gm-Message-State: AOJu0YxyGJ4mjeC/1mpomqQqNmmpN1QGFhcrEIfAImxU6hMmQhUGL1Eq 1DF8GxiW+uKxCH44g59Zoc8jK2/1B8rMny/RwcMIoQ1v7fgGd7EBiLV5EZQoFTw= X-Google-Smtp-Source: AGHT+IGPE6k3N5wdR11ZQ2KZFoj1Q7gGsWsY0UPRVz0U0AfRSYWIhLPL3AI9jKB/vygyWqnZmYfNvQ== X-Received: by 2002:a2e:a801:0:b0:2ee:4c2e:3d3b with SMTP id 38308e7fff4ca-2ee5e390286mr44525361fa.4.1719817361254; Mon, 01 Jul 2024 00:02:41 -0700 (PDT) Received: from lino.lan ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5861324f036sm4034383a12.34.2024.07.01.00.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 00:02:39 -0700 (PDT) From: Linus Walleij Date: Mon, 01 Jul 2024 09:02:14 +0200 Subject: [PATCH 3/4] ASoC: tas2781-i2c: Get the right GPIO line Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240701-asoc-tas-gpios-v1-3-d69ec5d79939@linaro.org> References: <20240701-asoc-tas-gpios-v1-0-d69ec5d79939@linaro.org> In-Reply-To: <20240701-asoc-tas-gpios-v1-0-d69ec5d79939@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shenghao Ding , Kevin Lu , Baojun Xu Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Shenghao Ding <13916275206@139.com>, alsa-devel@alsa-project.org, Linus Walleij X-Mailer: b4 0.14.0 The code is obtaining a GPIO reset using the reset GPIO name "reset-gpios", but the gpiolib is already adding the suffix "-gpios" to anything passed to this function and will be looking for "reset-gpios-gpios" which is most certainly not what the author desired. Fix it up. Fixes: ef3bcde75d06 ("ASoC: tas2781: Add tas2781 driver") Signed-off-by: Linus Walleij --- sound/soc/codecs/tas2781-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c index 1542915b83a2..256f2e8f1ba9 100644 --- a/sound/soc/codecs/tas2781-i2c.c +++ b/sound/soc/codecs/tas2781-i2c.c @@ -654,7 +654,7 @@ static void tasdevice_parse_dt(struct tasdevice_priv *tas_priv) tas_priv->tasdevice[i].dev_addr = dev_addrs[i]; tas_priv->reset = devm_gpiod_get_optional(&client->dev, - "reset-gpios", GPIOD_OUT_HIGH); + "reset", GPIOD_OUT_HIGH); if (IS_ERR(tas_priv->reset)) dev_err(tas_priv->dev, "%s Can't get reset GPIO\n", __func__);