| Message ID | 20240705063555.17220-1-tiwai@suse.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bc7540b794df29f6ec0b24996381d6e68779d02f |
| Headers | show |
| Series | ALSA: pcm: Fix missing export of snd_pcm_set_sync_per-card() | expand |
On 05. 07. 24 8:35, Takashi Iwai wrote: > The recent change for the PCM sync API forgot to export a new API > function that is currently used in emu10k1 driver. > > This patch adds the missing export. > > Fixes: d712c58c55d9 ("ALSA: pcm: optimize and clarify stream synchronization ID API") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202407051343.1Sz8AKFt-lkp@intel.com/ > Signed-off-by: Takashi Iwai <tiwai@suse.de> > --- > sound/core/pcm_lib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c > index e48a84f8e977..66683656fb13 100644 > --- a/sound/core/pcm_lib.c > +++ b/sound/core/pcm_lib.c > @@ -547,6 +547,7 @@ void snd_pcm_set_sync_per_card(struct snd_pcm_substream *substream, > strncpy(params->sync + 4, id, len); > memset(params->sync + 4 + len, 0, 12 - len); > } > +EXPORT_SYMBOL_GPL(snd_pcm_set_sync_per_card); > > /* > * Standard ioctl routine Reviewed-by: Jaroslav Kysela <perex@perex.cz> Thank you for this quick fix. I may also add this to the original patch set, if you like. Jaroslav
On Fri, 05 Jul 2024 09:38:28 +0200, Jaroslav Kysela wrote: > > On 05. 07. 24 8:35, Takashi Iwai wrote: > > The recent change for the PCM sync API forgot to export a new API > > function that is currently used in emu10k1 driver. > > > > This patch adds the missing export. > > > > Fixes: d712c58c55d9 ("ALSA: pcm: optimize and clarify stream synchronization ID API") > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202407051343.1Sz8AKFt-lkp@intel.com/ > > Signed-off-by: Takashi Iwai <tiwai@suse.de> > > --- > > sound/core/pcm_lib.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c > > index e48a84f8e977..66683656fb13 100644 > > --- a/sound/core/pcm_lib.c > > +++ b/sound/core/pcm_lib.c > > @@ -547,6 +547,7 @@ void snd_pcm_set_sync_per_card(struct snd_pcm_substream *substream, > > strncpy(params->sync + 4, id, len); > > memset(params->sync + 4 + len, 0, 12 - len); > > } > > +EXPORT_SYMBOL_GPL(snd_pcm_set_sync_per_card); > > /* > > * Standard ioctl routine > > > Reviewed-by: Jaroslav Kysela <perex@perex.cz> > > Thank you for this quick fix. I may also add this to the original > patch set, if you like. Note that the v7 patch set has been already merged, so only an incremental fix is necessary in anyway. thanks, Takashi
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index e48a84f8e977..66683656fb13 100644 --- a/sound/core/pcm_lib.c +++ b/sound/core/pcm_lib.c @@ -547,6 +547,7 @@ void snd_pcm_set_sync_per_card(struct snd_pcm_substream *substream, strncpy(params->sync + 4, id, len); memset(params->sync + 4 + len, 0, 12 - len); } +EXPORT_SYMBOL_GPL(snd_pcm_set_sync_per_card); /* * Standard ioctl routine
The recent change for the PCM sync API forgot to export a new API function that is currently used in emu10k1 driver. This patch adds the missing export. Fixes: d712c58c55d9 ("ALSA: pcm: optimize and clarify stream synchronization ID API") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202407051343.1Sz8AKFt-lkp@intel.com/ Signed-off-by: Takashi Iwai <tiwai@suse.de> --- sound/core/pcm_lib.c | 1 + 1 file changed, 1 insertion(+)