diff mbox series

[1/1] ASoC: mediatek: mt8188: add register to volatile_register

Message ID 20240801031030.31114-1-yr.yang@mediatek.com (mailing list archive)
State Accepted
Commit ff9f065318e17a1a97981d9e535fcfc6ce5d5614
Headers show
Series [1/1] ASoC: mediatek: mt8188: add register to volatile_register | expand

Commit Message

yr.yang Aug. 1, 2024, 3:10 a.m. UTC
From: YR Yang <yr.yang@mediatek.com>

Add AFE Control Register 0 to volatile_register.
AFE_DAC_CON0 can be modified by both SOF and ALSA driver.
If this register read & write by cache mode, 
the cached value may be not the real value
when the register modified by other side.
It will cause playback or capture fail.
Need add AFE_DAC_CON0 to volatile register.

Signed-off-by: YR Yang <yr.yang@mediatek.com>

---
 sound/soc/mediatek/mt8188/mt8188-afe-pcm.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Chen-Yu Tsai Aug. 1, 2024, 4:01 a.m. UTC | #1
Hi,

On Thu, Aug 1, 2024 at 11:11 AM yr.yang <yr.yang@mediatek.com> wrote:
>
> From: YR Yang <yr.yang@mediatek.com>
>
> Add AFE Control Register 0 to volatile_register.
> AFE_DAC_CON0 can be modified by both SOF and ALSA driver.
> If this register read & write by cache mode,
> the cached value may be not the real value
> when the register modified by other side.
> It will cause playback or capture fail.
> Need add AFE_DAC_CON0 to volatile register.

You should mention this specific register in the patch subject.
Something like:

ASoC: mediatek: mt8188: Mark AFE_DAC_CON0 register as volatile


ChenYu

> Signed-off-by: YR Yang <yr.yang@mediatek.com>
>
> ---
>  sound/soc/mediatek/mt8188/mt8188-afe-pcm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c b/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
> index ccb6c1f3adc7..73e5c63aeec8 100644
> --- a/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
> +++ b/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
> @@ -2748,6 +2748,7 @@ static bool mt8188_is_volatile_reg(struct device *dev, unsigned int reg)
>         case AFE_ASRC12_NEW_CON9:
>         case AFE_LRCK_CNT:
>         case AFE_DAC_MON0:
> +       case AFE_DAC_CON0:
>         case AFE_DL2_CUR:
>         case AFE_DL3_CUR:
>         case AFE_DL6_CUR:
> --
> 2.34.1
>
>
diff mbox series

Patch

diff --git a/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c b/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
index ccb6c1f3adc7..73e5c63aeec8 100644
--- a/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
+++ b/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
@@ -2748,6 +2748,7 @@  static bool mt8188_is_volatile_reg(struct device *dev, unsigned int reg)
 	case AFE_ASRC12_NEW_CON9:
 	case AFE_LRCK_CNT:
 	case AFE_DAC_MON0:
+	case AFE_DAC_CON0:
 	case AFE_DL2_CUR:
 	case AFE_DL3_CUR:
 	case AFE_DL6_CUR: