| Message ID | 20240810150939.330693-1-parsa.poorsh@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: hda/realtek: Fix noise from speakers on Lenovo IdeaPad 3 15IAU7 | expand |
On Sat, 10 Aug 2024 17:09:06 +0200, Parsa Poorshikhian wrote: > > Fixes: 70794b9563fe ("ALSA: hda/realtek: Add more codec ID to no shutup pins list") The Fixes tag should be around Signed-off-by tag. > Fix noise from speakers connected to AUX port when no sound is playing. > The problem occurs because the `alc_shutup_pins` function includes > a 0x10ec0257 vendor ID, which causes noise on Lenovo IdeaPad 3 15IAU7 with > Realtek ALC257 codec when no sound is playing. > Removing this vendor ID from the function fixes the bug. > > Signed-off-by: Parsa Poorshikhian <parsa.poorsh@gmail.com> Applied with a minor modification above. Thanks! Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index e2dbcf8f5bcf..7b593642da99 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -583,7 +583,6 @@ static void alc_shutup_pins(struct hda_codec *codec) switch (codec->core.vendor_id) { case 0x10ec0236: case 0x10ec0256: - case 0x10ec0257: case 0x19e58326: case 0x10ec0283: case 0x10ec0285:
Fixes: 70794b9563fe ("ALSA: hda/realtek: Add more codec ID to no shutup pins list") Fix noise from speakers connected to AUX port when no sound is playing. The problem occurs because the `alc_shutup_pins` function includes a 0x10ec0257 vendor ID, which causes noise on Lenovo IdeaPad 3 15IAU7 with Realtek ALC257 codec when no sound is playing. Removing this vendor ID from the function fixes the bug. Signed-off-by: Parsa Poorshikhian <parsa.poorsh@gmail.com> --- sound/pci/hda/patch_realtek.c | 1 - 1 file changed, 1 deletion(-)